Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: API bump & reconcile feature gates move #4335

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

djoshy
Copy link
Contributor

@djoshy djoshy commented Apr 24, 2024

- What I did

  • bumps o/api, o/client-go, o/library-go and updates CRDs into install/
  • updates all refs for feature gates to the new package

- How to verify it
All e2es should pass. This PR doesn't introduce any new behavior.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2024
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@djoshy
Copy link
Contributor Author

djoshy commented Apr 24, 2024

/test unit
/test verify
/test e2e-gcp-op
/test e2e-gcp-op-techpreview

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@djoshy
Copy link
Contributor Author

djoshy commented Apr 25, 2024

/test all

@djoshy djoshy changed the title api bump for fg move NO-ISSUE: API bump & reconcile feature gates move Apr 25, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2024
@openshift-ci-robot
Copy link
Contributor

@djoshy: This pull request explicitly references no jira issue.

In response to this:

- What I did

  • bumps o/api, o/client-go, o/library-go and updates CRDs into install/
  • updates to envtest to keep with o/api's divergence
  • updates all refs for feature gates to the new package

- How to verify it
All e2es should pass. This PR doesn't introduce any new behavior.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Contributor Author

djoshy commented Apr 25, 2024

/test security

1 similar comment
@djoshy
Copy link
Contributor Author

djoshy commented Apr 25, 2024

/test security

@djoshy djoshy marked this pull request as ready for review April 26, 2024 20:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2024
Copy link
Contributor

openshift-ci bot commented Apr 27, 2024

@djoshy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 0b0840b link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sinnykumari
Copy link
Contributor

LGTM. Thanks David for looking into API update with latest feature moves.
/lgtm
/retest
Putting hold to double check with Ines to make sure we are ready to adapt #4327 accordingly
/cc @inesqyx
/hold

@openshift-ci openshift-ci bot requested a review from inesqyx April 29, 2024 10:10
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inesqyx
Copy link
Contributor

inesqyx commented Apr 29, 2024

Looks sane to me :) Working on OCL adaptation...
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2aa3bbd into openshift:master Apr 29, 2024
15 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202404300240.p0.g2aa3bbd.assembly.stream.el9 for distgit ose-machine-config-operator.
All builds following this will include this PR.

@djoshy djoshy deleted the fg-move-bump branch April 30, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants