OCPBUGS-33046: improve status reporting for pinned image sets

[hexfusion]

This PR improves status updates to MCN and MCP while PinnedImageSets are reconciling.

Changes:

• node controller status properly calculates update machines
• node controller will sync if a pool attached to a node is currently reconciling pinnedImageSets. This gives a faster feedback loop when nodes have updated or errored.
• add poolSyncronizer logic to MCN status to provide finer grained status reporting for MCP poolSyncronizers.
• refactoring of status population in PinnedImageSet Manager
• additional feature gating

[openshift-ci-robot]

@hexfusion: This pull request references Jira Issue OCPBUGS-33046, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[hexfusion]

/hold testing

[openshift-ci-robot]

@hexfusion: This pull request references Jira Issue OCPBUGS-33046, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

This PR improves status updates to MCN and MCP while PinnedImageSets are reconciling.

Changes:

• node controller status properly calculates update machines
• node controller will sync if a pool attached to a node is currently reconciling pinnedImageSets. This gives a faster feedback loop when nodes have updated or errored.
• add poolSyncronizer logic to MCN status to provide finer grained status reporting for MCP poolSyncronizers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sergiordlr]

Verified using these steps:

1. Enable techpreview
2. Create a pinnedimageset to pin a single image

apiVersion: machineconfiguration.openshift.io/v1alpha1
kind: PinnedImageSet
metadata:
  labels:
    machineconfiguration.openshift.io/role: worker
  name: my-worker-pinned-images
spec:
  pinnedImages:
  - name: "quay.io/.../...@sha256:0415f56ccc05526f2af5a7ae8654baec97d4a6....."

3.Add 10 nodes to the worker pool
4. Check that the pinnedset poolSynchronizersStatus is updated accordingly and fast enough

oc get mcp worker -o yaml 
...
  poolSynchronizersStatus:
  - availableMachineCount: 12
    machineCount: 12
    poolSynchronizerType: PinnedImageSets
    readyMachineCount: 12
    unavailableMachineCount: 0
    updatedMachineCount: 12

It took a few seconds to update the status with the right values.

We add the qe-approved label

/label qe-approved

[sinnykumari]

Looks sane.

[hexfusion]

/hold cancel

[hexfusion]

the value of childDNEOrIsTheSame could only ever be changed here but then could never be consumed.

[yuqi-zhang]

/lgtm

Just a question inline (but non-blocking)

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2766d7c and 2 for PR HEAD bede30f in total

[yuqi-zhang]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, sinnykumari, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sinnykumari,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 5a6e8b8 and 2 for PR HEAD 8cbdc2a in total

[hexfusion]

/retest-required

[openshift-ci]

@hexfusion: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	8cbdc2a	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@hexfusion: Jira Issue OCPBUGS-33046: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#4339

Jira Issue OCPBUGS-33046 has been moved to the MODIFIED state.

In response to this:

This PR improves status updates to MCN and MCP while PinnedImageSets are reconciling.

Changes:

• node controller status properly calculates update machines
• node controller will sync if a pool attached to a node is currently reconciling pinnedImageSets. This gives a faster feedback loop when nodes have updated or errored.
• add poolSyncronizer logic to MCN status to provide finer grained status reporting for MCP poolSyncronizers.
• refactoring of status population in PinnedImageSet Manager
• additional feature gating

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202405072356.p0.g7dea103.assembly.stream.el9 for distgit ose-machine-config-operator.
All builds following this will include this PR.