Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33018: pkg/daemon: logSystem the Kube API errors that trigger a re-bootstrap #4342

Conversation

wking
Copy link
Member

@wking wking commented May 1, 2024

OCPBUGS-33018 is wrestling with some surprise kubeletRebootstrap ErrAuxiliary 255 exits. Once the container exits, replacement containers crash-loop on content mismatch for file, which means that it's hard to get details about the error condition that triggered the re-bootstrap (and then exited leaving dirty disk state). By writing the error to the system logs, we're more likely to be able to understand what went wrong, and this will help us maintain the strings.Contains filtering going forward. If we notice re-bootstrap triggers that don't look like things that a re-bootstrap would help resolve, we can drop or adjust that trigger.

[1] is wrestling with some surprise kubeletRebootstrap ErrAuxiliary
255 exits.  Once the container exits, replacement containers
crash-loop on 'content mismatch for file' [2], which means that it's
hard to get details about the error condition that triggered the
re-bootstrap (and then exited leaving dirty disk state).  By writing
the error to the system logs, we're more likely to be able to
understand what went wrong, and this will help us maintain the
strings.Contains filtering going forward.  If we notice re-bootstrap
triggers that don't look like things that a re-bootstrap would help
resolve, we can drop or adjust that trigger.

[1]: https://issues.redhat.com/browse/OCPBUGS-33018
[2]: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-metal-ipi-upgrade-ovn-ipv6/1785416317164064768/artifacts/e2e-metal-ipi-upgrade-ovn-ipv6/gather-extra/artifacts/pods/openshift-machine-config-operator_machine-config-daemon-p79jz_machine-config-daemon_previous.log
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 1, 2024
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Jira Issue OCPBUGS-33018, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-33018 is wrestling with some surprise kubeletRebootstrap ErrAuxiliary 255 exits. Once the container exits, replacement containers crash-loop on content mismatch for file, which means that it's hard to get details about the error condition that triggered the re-bootstrap (and then exited leaving dirty disk state). By writing the error to the system logs, we're more likely to be able to understand what went wrong, and this will help us maintain the strings.Contains filtering going forward. If we notice re-bootstrap triggers that don't look like things that a re-bootstrap would help resolve, we can drop or adjust that trigger.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wking
Copy link
Member Author

wking commented May 1, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 1, 2024
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Jira Issue OCPBUGS-33018, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 1, 2024
@openshift-ci openshift-ci bot requested a review from sergiordlr May 1, 2024 23:05
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2024
Copy link
Contributor

openshift-ci bot commented May 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a9a5832 and 2 for PR HEAD 7df3a46 in total

Copy link
Contributor

openshift-ci bot commented May 2, 2024

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 203afde into openshift:master May 2, 2024
15 checks passed
@openshift-ci-robot
Copy link
Contributor

@wking: Jira Issue OCPBUGS-33018: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33018 has been moved to the MODIFIED state.

In response to this:

OCPBUGS-33018 is wrestling with some surprise kubeletRebootstrap ErrAuxiliary 255 exits. Once the container exits, replacement containers crash-loop on content mismatch for file, which means that it's hard to get details about the error condition that triggered the re-bootstrap (and then exited leaving dirty disk state). By writing the error to the system logs, we're more likely to be able to understand what went wrong, and this will help us maintain the strings.Contains filtering going forward. If we notice re-bootstrap triggers that don't look like things that a re-bootstrap would help resolve, we can drop or adjust that trigger.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202405020546.p0.g203afde.assembly.stream.el9 for distgit ose-machine-config-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-05-08-222442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants