Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCO: clear out failing status on success and add tests #442

Merged
merged 4 commits into from
Feb 17, 2019
Merged

MCO: clear out failing status on success and add tests #442

merged 4 commits into from
Feb 17, 2019

Commits on Feb 17, 2019

  1. pkg/operator: clear out failing status 

    Fix a bug reported in openshift#406 (comment)
where we weren't properly resetting the failing status.

Signed-off-by: Antonio Murdaca <runcom@linux.com>
    @runcom
    runcom committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    5b1ee9f View commit details
    Browse the repository at this point in the history

  2. MCO: refactor code for unit testing and add one 

    Specifically, add a test to verify that we're clearing out the failing
condition on subsequent sync operations (covering a bug reported here
openshift#406 (comment))

Signed-off-by: Antonio Murdaca <runcom@linux.com>
    @runcom
    runcom committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    146ea72 View commit details
    Browse the repository at this point in the history

  3. pkg/operator: add sync status unit tests 

    Signed-off-by: Antonio Murdaca <runcom@linux.com>
    @runcom
    runcom committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    e1c97fd View commit details
    Browse the repository at this point in the history

  4. pkg/operator: add test for inClusterBringUp staying on error 

    Signed-off-by: Antonio Murdaca <runcom@linux.com>
    @runcom
    runcom committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    2a582a9 View commit details
    Browse the repository at this point in the history