Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/controller: resync on unavailable #601

Closed
wants to merge 2 commits into from
Closed

pkg/controller: resync on unavailable #601

wants to merge 2 commits into from

Conversation

kikisdeliveryservice
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice commented Apr 3, 2019 •
edited

- What I did

  • add check to syncStatusOnly to allow for resync of status when
    an unavailable machine or unupdated machines are found.
  • update unit tests to account for new error generated in syncStatusOnly

Closes BZ 1695721

- How to verify it
CI runs should now pass without the error.

@kikisdeliveryservice
controller: resync on unavailable & unupdated
b8093eb 
add check to syncStatusOnly to allow for resync of status when
an unavailable machine or unupdated machines are found.
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2019
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 3, 2019
@kikisdeliveryservice kikisdeliveryservice requested review from runcom and removed request for ashcrow and LorbusChris April 3, 2019 18:44
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2019
@kikisdeliveryservice
Copy link
Contributor Author

a few unit tests are broken, need to update them.

@kikisdeliveryservice
Copy link
Contributor Author

could not wait for build: the build machine-config-server failed after 1m21s with reason DockerBuildFailed: Docker build strategy has failed.

not sure why, so retesting..
/retest

@kikisdeliveryservice
Copy link
Contributor Author

so unit tests were initially failing because it falled f.run() instead of f.runExpectedError() which is what we'd now expect given the existence of the new unavailable/not updated check initially.

@kikisdeliveryservice kikisdeliveryservice changed the title [WIP] controller: resync on unavailable [WIP] pkg/controller: resync on unavailable Apr 3, 2019
@kikisdeliveryservice kikisdeliveryservice changed the title [WIP] pkg/controller: resync on unavailable pkg/controller: resync on unavailable Apr 3, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2019
runcom
runcom reviewed Apr 4, 2019
View reviewed changes
pkg/controller/node/node_controller_test.go
@@ -816,7 +816,7 @@ func TestPaused(t *testing.T) {
expMcp.Status = expStatus
f.expectUpdateMachineConfigPoolStatus(expMcp)

f.run(getKey(mcp, t))
f.runExpectError(getKey(mcp, t))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we now have a successful test where f.run just runs? (mocking machines len)

@runcom
Copy link
Member

runcom commented Apr 4, 2019

/hold

after taking a closer look at https://bugzilla.redhat.com/show_bug.cgi?id=1695721, it looks like the MCO isn't causing any issue so I'm holding this until Trevor further clarifies why the MCO (apart from the transient) error is causing the upgrade to fail.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2019
@kikisdeliveryservice
Copy link
Contributor Author

makes sense @runcom

@runcom
Copy link
Member

runcom commented Apr 23, 2019

/hold cancel

not sure how we would ever get in such scenario where we don't resync anymore (and need this) but looks like we're getting reports that we can fall into this...

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2019
@runcom
Copy link
Member

runcom commented Apr 23, 2019

/hold

I shouldn't have removed hold tho 😄

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2019
@kikisdeliveryservice
Copy link
Contributor Author

/skip

@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws bbe24a5 link /test e2e-aws
ci/prow/e2e-aws-op bbe24a5 link /test e2e-aws-op
ci/prow/e2e-aws-disruptive bbe24a5 link /test e2e-aws-disruptive
ci/prow/e2e-gcp-op bbe24a5 link /test e2e-gcp-op
ci/prow/e2e-gcp-upgrade bbe24a5 link /test e2e-gcp-upgrade
ci/prow/e2e-vsphere bbe24a5 link /test e2e-vsphere

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice kikisdeliveryservice added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 3, 2019
@kikisdeliveryservice
Copy link
Contributor Author

In an effort to clean up the MCO repo, closing old open PRs with no recent activity.

Feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runcom runcom runcom left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kikisdeliveryservice @openshift-ci-robot @runcom