Drop os_version label on nodes #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
the
approved
|
Supercedes #584 |
|
/test images |
|
can this go into 4.1 then if it's not required? |
|
to be held for 4.2 |
openshift-ci-robot
added
the
do-not-merge/hold
|
/test e2e-aws-scaleup |
It isn't useful today because most containers just want the RHEL major which they can't get at without parsing it, and you can't do that in a selector. Also, it turns out that the label commandline is a one-shot. We need to move any label version updates into the MCD.
cgwalters
force-pushed
the
drop-version-label
branch
from
21fc2ad
to
d5a63f2
Compare
openshift-ci-robot
added
size/XS
|
Rebased 🏄♂️ |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't useful today because most containers just want the RHEL major
which they can't get at without parsing it, and you can't do that
in a selector.
Also, it turns out that the label commandline is a one-shot. We
need to move any label version updates into the MCD.