docs/README: provide base64 encoded example #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find it much easier to use `base64` to encode file content than other methods. Providing a pointer here may also save some headaches for other users.
openshift-ci-robot
added
the
size/XS
|
Maybe it is just me, but using |
|
/approve |
openshift-ci-robot
added
the
approved
|
👍 thanks @miabbott ! (this is also great cause in theory, you could ship a binary fine by base64 encoding it) /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, miabbott, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Updated the docs with a
base64encoded example- How to verify it
Apply the example MachineConfig and verify the file is landed on nodes
- Description for the changelog
docs/README: Provided an example of using
base64encoded file contents