Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignition types.Config (v0s2) to runtime.RawExtension conversion #996

Merged
merged 4 commits into from
Apr 5, 2020
Merged

Ignition types.Config (v0s2) to runtime.RawExtension conversion #996

merged 4 commits into from
Apr 5, 2020

Commits on Apr 3, 2020

  1. Move MergeMachineConfigs func into controller/common pkg 

    In preparation of decoupling the API from Ignition Config types.
    @LorbusChris
    LorbusChris committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    6b2ecad View commit details
    Browse the repository at this point in the history

  2. test/e2e/utils_test.go: Use test/helpers.NewMachineConfig in createMC… 

    … func

In preparation of moving to RawExtension, this aligns creation of new valid MCs for tests.
    @LorbusChris
    LorbusChris committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    14fc99f View commit details
    Browse the repository at this point in the history

  3. pkg/controller/common: Add KernelType constants 

    and use them in pkg/controller/common/helpers.go as well as
pkg/daemon/update.go
    @LorbusChris
    LorbusChris committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    c3d970c View commit details
    Browse the repository at this point in the history

  4. Convert Ignition types.Config to runtime.RawExtension 

    In order to decouple the MCO's API from the Ignition types,
this PR introduces conversion to and from RawExtension.

When reading or mutating a config, the RawExtension is now parsed to
a typed Ignition config internally upon receival, and then converted
back to RawExtension for passing it around externally. The Ignition
Parse function also does validation of the config.

Using RawExtension does not change the wire-format of the
transmitted data. The contents of MachineConfig.Spec.Config
will still be in JSON format and readable as such.
    @LorbusChris
    LorbusChris committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    7a18cfb View commit details
    Browse the repository at this point in the history