-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSD-23318: Allow to modify IDMS in HCP hosted clusters #309
base: master
Are you sure you want to change the base?
OSD-23318: Allow to modify IDMS in HCP hosted clusters #309
Conversation
@samanthajayasinghe: This pull request references OSD-23318 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f59e5c0
to
7c3c5ea
Compare
Great work Sam! this all looks good to me :). One question - why did we change the |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hectorakemp, samanthajayasinghe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7c3c5ea
to
0cc99b8
Compare
New changes are detected. LGTM label has been removed. |
@samanthajayasinghe: This pull request references OSD-23318 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3d105d0
to
c3292c5
Compare
@samanthajayasinghe: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@samanthajayasinghe: This pull request references OSD-23318 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
What
As part of zero-egress implementation, hosted clusters IDMS needs to update with private ECR
JIRA
https://issues.redhat.com/browse/OSD-23318