Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-23318: Allow to modify IDMS in HCP hosted clusters #309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samanthajayasinghe
Copy link
Contributor

@samanthajayasinghe samanthajayasinghe commented Jun 6, 2024

What

As part of zero-egress implementation, hosted clusters IDMS needs to update with private ECR

  • This PR allows mirroring ECR's for hosted clusters via the feature flag
  • backplane service account allows to update IDMS/ICSP/ITMS

JIRA

https://issues.redhat.com/browse/OSD-23318

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2024

@samanthajayasinghe: This pull request references OSD-23318 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

What

Allow hypershift / package opertor system account to change hosted cluster IDMS/ICSP

JIRA

https://issues.redhat.com/browse/OSD-23318

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hectorakemp
Copy link
Contributor

Great work Sam! this all looks good to me :). One question - why did we change the SyncSetLabelSelector on the webhook? Was that part of the generated make code?
Happy to lgtm if tested :)
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2024
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hectorakemp, samanthajayasinghe
Once this PR has been reviewed and has the lgtm label, please assign nautilux for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2024
Copy link
Contributor

openshift-ci bot commented Jun 16, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2024

@samanthajayasinghe: This pull request references OSD-23318 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

What

As part of zero-egress implementation, hosted clusters IDMS needs to update with private ECR

  • This PR allows mirroring ECR's for hosted clusters
  • backplane service account allows to update IDMS/ICSP/ITMS

JIRA

https://issues.redhat.com/browse/OSD-23318

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@samanthajayasinghe samanthajayasinghe changed the title OSD-23318: Allow hypershift system account to make changes to IDMS/ICSP OSD-23318: Allow to modify IDMS in HCP hosted clusters Jun 17, 2024
Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

@samanthajayasinghe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 21, 2024

@samanthajayasinghe: This pull request references OSD-23318 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

What

As part of zero-egress implementation, hosted clusters IDMS needs to update with private ECR

  • This PR allows mirroring ECR's for hosted clusters via the feature flag
  • backplane service account allows to update IDMS/ICSP/ITMS

JIRA

https://issues.redhat.com/browse/OSD-23318

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants