Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed non bundleable resources from deploy directory #118

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Removed non bundleable resources from deploy directory #118

merged 1 commit into from
Apr 16, 2021

Conversation

arjunrn
Copy link
Contributor

@arjunrn arjunrn commented Apr 16, 2021

Removed resources from /deploy directory which cause the bundle contents to be broken.

Romoved non bundleable resources from deploy directory
0719920 
Signed-off-by: Arjun Naik <anaik@redhat.com>
@arjunrn arjunrn changed the title Romoved non bundleable resources from deploy directory Removed non bundleable resources from deploy directory Apr 16, 2021
jharrington22
jharrington22 approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@jharrington22 jharrington22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Validated that this works locally by building a new registry and pushing it to a staging cluster

$ oc get csv -n openshift-velero
NAME                                               DISPLAY                           VERSION           REPLACES                                           PHASE
configure-alertmanager-operator.v0.1.311-151f7d3   configure-alertmanager-operator   0.1.311-151f7d3   configure-alertmanager-operator.v0.1.309-621e499   Succeeded
managed-velero-operator.v0.2.251-1d6a330           managed-velero-operator           0.2.251-1d6a330   managed-velero-operator.v0.2.250-68edac2           Succeeded
route-monitor-operator.v0.1.260-c12ed28            Route Monitor Operator            0.1.260-c12ed28   route-monitor-operator.v0.1.258-aa2b329            Succeeded

The VeleroInstall CR is missing but is applied by MCC here

The roles in MCC here can be removed since they are being added to the CSV and being bound to the right service account

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2021
@cblecker
Copy link
Member

/approve

@jharrington22
Copy link
Contributor

Credentials requests are deployed by SelectorSyncSet in the OC template here

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arjunrn, cblecker, jharrington22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2021
@openshift-merge-robot openshift-merge-robot merged commit 93541bf into openshift:master Apr 16, 2021
@arjunrn arjunrn deleted the remove-extraneous-resources-deploy branch April 16, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharrington22 jharrington22 jharrington22 approved these changes

@luis-falcon luis-falcon Awaiting requested review from luis-falcon

@yithian yithian Awaiting requested review from yithian

Assignees

@jharrington22 jharrington22

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
5 participants
@arjunrn @cblecker @jharrington22 @openshift-ci-robot @openshift-merge-robot