Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download and cache go modules in builder container #15

Merged
merged 3 commits into from Sep 9, 2019

Conversation

@cblecker
Copy link
Member

commented Sep 5, 2019

By copying in just the go.mod and go.sum files, and then running a go mod download, we cache the docker layer with the modules and don't need to redownload them each time the code changes. We'll only discard that layer if the go.mod/sum files actually change.

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

/assign @lisa

@lisa

This comment has been minimized.

Copy link

commented Sep 5, 2019

/retest

maybe apache is back up?

@cblecker if this apache issue persists should we resume with the proxy?

@lisa

This comment has been minimized.

Copy link

commented Sep 6, 2019

/retest

@cblecker cblecker force-pushed the cblecker:docker-cache branch from 739d74d to 4339dc8 Sep 6, 2019

@cblecker cblecker force-pushed the cblecker:docker-cache branch from 4339dc8 to b908ca0 Sep 6, 2019

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

/test verify

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

@lisa Tests are passing now :)

@lisa

This comment has been minimized.

Copy link

commented Sep 9, 2019

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Sep 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, lisa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b58ac36 into openshift:master Sep 9, 2019

4 checks passed

ci/prow/images Job succeeded.
Details
ci/prow/test Job succeeded.
Details
ci/prow/verify Job succeeded.
Details
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:docker-cache branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.