Download and cache go modules in builder container #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/S
|
/assign @lisa |
|
/retest maybe apache is back up? @cblecker if this apache issue persists should we resume with the proxy? |
|
/retest |
cblecker
force-pushed
the
docker-cache
branch
from
739d74d
to
4339dc8
Compare
cblecker
force-pushed
the
docker-cache
branch
from
4339dc8
to
b908ca0
Compare
|
/test verify |
|
@lisa Tests are passing now :) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, lisa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By copying in just the go.mod and go.sum files, and then running a
go mod download, we cache the docker layer with the modules and don't need to redownload them each time the code changes. We'll only discard that layer if the go.mod/sum files actually change.