Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to get AWS platform and region #3

Merged

Conversation

@cblecker
Copy link
Member

commented Aug 7, 2019

No description provided.

cblecker added some commits Aug 7, 2019

@c-e-brumm

This comment has been minimized.

Copy link

commented Aug 7, 2019

With "kube-system" "cluster-config-v1" and "install-config" all as hardcoded strings is there a future where this pkg grows and we benefit from moving those to constants? If not that's fine.

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

@c-e-brumm Good question! The cluster-config-v1 configmap is actually being deprecated and is removed completely in 4.2 (that's the reason for this PR). This allows the code to work under both a 4.1 and 4.2 scenario. As those hard coded strings all relate to 4.1 world, I don't think they would benefit from moving to constants.

@c-e-brumm

This comment has been minimized.

Copy link

commented Aug 7, 2019

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Aug 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c-e-brumm, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4b132ba into openshift:master Aug 7, 2019

1 of 2 checks passed

tide Not mergeable.
Details
ci/prow/images Job succeeded.
Details

@cblecker cblecker deleted the cblecker:util-platform-region branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.