Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to get AWS platform and region #3

Merged

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Aug 7, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 7, 2019
@c-e-brumm
Copy link
Contributor

With "kube-system" "cluster-config-v1" and "install-config" all as hardcoded strings is there a future where this pkg grows and we benefit from moving those to constants? If not that's fine.

@cblecker
Copy link
Member Author

cblecker commented Aug 7, 2019

@c-e-brumm Good question! The cluster-config-v1 configmap is actually being deprecated and is removed completely in 4.2 (that's the reason for this PR). This allows the code to work under both a 4.1 and 4.2 scenario. As those hard coded strings all relate to 4.1 world, I don't think they would benefit from moving to constants.

@c-e-brumm
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c-e-brumm, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4b132ba into openshift:master Aug 7, 2019
@cblecker cblecker deleted the util-platform-region branch August 7, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
4 participants