Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move velero deployment to infra nodes #30

Merged

Conversation

NautiluX
Copy link
Contributor

@NautiluX NautiluX commented Jan 7, 2020

As infra nodes are existing in all OSD v4 clusters,
velero deployments should be moved to infra nodes.

@NautiluX NautiluX requested a review from cblecker January 7, 2020 15:26
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 7, 2020
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2020
@NautiluX
Copy link
Contributor Author

NautiluX commented Jan 7, 2020

/hold I want to check the affinity config locally before merging

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2020
Copy link
Member

@jewzaam jewzaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

deploy/operator.yaml Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2020
@NautiluX
Copy link
Contributor Author

NautiluX commented Jan 8, 2020

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2020
@NautiluX NautiluX force-pushed the move-velero-to-infra branch 2 times, most recently from e2509f0 to 6e18a91 Compare January 8, 2020 10:03
As infra nodes are existing in all OSD v4 clusters,
velero deployments should be moved to infra nodes.
@cblecker
Copy link
Member

cblecker commented Jan 8, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jewzaam, NautiluX

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e4ab9b9 into openshift:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
5 participants