Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include "replaces:" field if a previous version was provided #80

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

blrm
Copy link
Contributor

@blrm blrm commented Jun 29, 2020

The "replaces" field on the CSV currently doesn't populate correctly because there is no previous version to refer to. This changes the generator to only include that field is a previous version was provided.

@blrm
Copy link
Contributor Author

blrm commented Jun 29, 2020

/assign @mbarnes

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   10.84%   10.84%           
=======================================
  Files          18       18           
  Lines        1106     1106           
=======================================
  Hits          120      120           
  Misses        973      973           
  Partials       13       13           

@mbarnes
Copy link
Contributor

mbarnes commented Jun 29, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blrm, mbarnes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit bc5b8df into openshift:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
4 participants