Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1936539: Update zeroconf to pull in rate-limiting fix #27

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #21

/assign cybertron

Vendor the latest zeroconf that includes better rate-limiting to
avoid saturating the network with multicast traffic.
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1898097 has been cloned as Bugzilla bug 1936539. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1936539: Update zeroconf to pull in rate-limiting fix

In response to this:

[release-4.6] Bug 1898097: Update zeroconf to pull in rate-limiting fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1898097: Update zeroconf to pull in rate-limiting fix [release-4.6] Bug 1936539: Update zeroconf to pull in rate-limiting fix Mar 8, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Mar 8, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1936539, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1898097 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1898097 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (osher@redhat.com), skipping review request.

In response to this:

[release-4.6] Bug 1936539: Update zeroconf to pull in rate-limiting fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 8, 2021
@cybertron
Copy link
Member

/test e2e-openstack
/test e2e-ovirt
/test e2e-vsphere
/cc @mandre @Gal-Zaidman @jcpowermac @patrickdillon

I'm not sure we have all of the platform jobs configured against this repo, but for everyone's awareness we had a request to backport this fix.

@openshift-ci-robot
Copy link
Contributor

@cybertron: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-metal-ipi
  • /test gofmt
  • /test govet
  • /test images
  • /test unit

Use /test all to run all jobs.

In response to this:

/test e2e-openstack
/test e2e-ovirt
/test e2e-vsphere
/cc @mandre @Gal-Zaidman @jcpowermac @patrickdillon

I'm not sure we have all of the platform jobs configured against this repo, but for everyone's awareness we had a request to backport this fix.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, no problem merging this from my side. Looks like the job passed for BM and I don't think this has the potential of breaking other platforms.

@Gal-Zaidman
Copy link

All good on my side as well, thanks for the update

@bcrochet
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2021
@celebdor
Copy link
Contributor

/lgtm

@celebdor
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet, celebdor, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crawford crawford added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 13, 2021
@crawford crawford changed the title [release-4.6] Bug 1936539: Update zeroconf to pull in rate-limiting fix Bug 1936539: Update zeroconf to pull in rate-limiting fix Mar 13, 2021
@openshift-merge-robot openshift-merge-robot merged commit 793a43f into openshift:release-4.6 Mar 13, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1936539 has been moved to the MODIFIED state.

In response to this:

Bug 1936539: Update zeroconf to pull in rate-limiting fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants