Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2115812: Enable l2advertisment validating webhook #116

Merged
merged 3 commits into from Nov 23, 2022
Merged

Bug 2115812: Enable l2advertisment validating webhook #116

merged 3 commits into from Nov 23, 2022

Conversation

pperiyasamy
Copy link
Member

No description provided.

pperiyasamy and others added 2 commits September 6, 2022 09:10
@pperiyasamy
Enable webhook for l2adv crd
5875d80 
This commit would enable validation webhook for l2advertisment
crd which doesn't currently work on the 4.12 deployments.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
(cherry picked from commit 7d96c4d)
@fedepaol @pperiyasamy
Bump the metallb version
5d57532 
Includes the renaming of the validating webhook configuration when
deploying via manifests.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
(cherry picked from commit 363d57b)
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 6, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2022

@pperiyasamy: This pull request references Bugzilla bug 2115812, which is invalid:

  • expected dependent Bugzilla bug 2100845 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2115812: Enable l2advertisment validating webhook

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dcbw and dougbtv September 6, 2022 07:40
@pperiyasamy
Enable l2adv webhook for 4.11 manifest
e6777d1 
Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
(cherry picked from commit 1df11b9)
@pperiyasamy
Copy link
Member Author

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2022

@pperiyasamy: This pull request references Bugzilla bug 2115812, which is invalid:

  • expected dependent Bugzilla bug 2100845 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pperiyasamy
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 10, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2022

@pperiyasamy: This pull request references Bugzilla bug 2115812, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.z) matches configured target release for branch (4.11.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2100845 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2100845 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @asood-rh

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from asood-rh November 10, 2022 08:07
@fedepaol
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022
@fedepaol
Copy link
Member

/override ci/prow/operator-e2e-upgrade

@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2022

@fedepaol: Overrode contexts on behalf of fedepaol: ci/prow/operator-e2e-upgrade

In response to this:

/override ci/prow/operator-e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2022

@pperiyasamy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fedepaol
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 10, 2022
@asood-rh
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit 64ad620 into openshift:release-4.11 Nov 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 23, 2022

@pperiyasamy: Bugzilla bug 2115812 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Bug 2115812: Enable l2advertisment validating webhook

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pperiyasamy pperiyasamy deleted the l2adv-fix branch November 23, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@dougbtv dougbtv Awaiting requested review from dougbtv

@asood-rh asood-rh Awaiting requested review from asood-rh

Assignees

@fedepaol fedepaol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pperiyasamy @fedepaol @asood-rh @openshift-merge-robot