Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-7315: Fix linting error #138

Merged
merged 1 commit into from Feb 10, 2023

Conversation

@openshift-ci
Copy link

openshift-ci bot commented Feb 9, 2023

@thegreyd: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix linting error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 9, 2023

@thegreyd: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix linting error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 9, 2023

@thegreyd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fedepaol
Copy link
Member

/retitle OCPBUGS-7315: Fix linting error

@openshift-ci openshift-ci bot changed the title Fix linting error OCPBUGS-7315: Fix linting error Feb 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2023

@thegreyd: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-7315: Fix linting error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 10, 2023
@openshift-ci-robot
Copy link

@thegreyd: This pull request references Jira Issue OCPBUGS-7315, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.10.z) matches configured target version for branch (4.10.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-7314 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-7314 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact:
/cc @asood-rh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is tripping the cvp test http://external-ci-coldstorage.datahub.redhat.com/cvp/cvp-redhat-operator-bundle-image-validation-test/ose-metallb-operator-bundle-container-v4.10.0.202302072301.p0.g186cf6b.assembly.stream-1/0898ccd9-df79-487e-aeee-d2cd44ebfe97/operator-metadata-linting-bundle-image-output.txt
gchat thread https://chat.google.com/room/AAAAZrx3KlI/qz4dtG_kSRw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from asood-rh February 10, 2023 09:04
@fedepaol
Copy link
Member

/approve
/lgtm

@fedepaol
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Feb 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol, thegreyd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@cgoncalves
Copy link

This seems more like an issue in the linter used by the CVP system.

Per the latest YAML specification (v1.2.2), the grammar allows trailing commas in sequences:

Flow collection entries are terminated by the “,” indicator. The final “,” may be omitted.

https://yaml.org/spec/1.2.2/#74-flow-collection-styles

No biggy in "fixing" this in MetalLB Operator but you may encounter this false-positive linter error elsewhere as well.

@asood-rh
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit b7a963e into openshift:release-4.10 Feb 10, 2023
@openshift-ci-robot
Copy link

@thegreyd: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-7315 has been moved to the MODIFIED state.

In response to this:

This is tripping the cvp test http://external-ci-coldstorage.datahub.redhat.com/cvp/cvp-redhat-operator-bundle-image-validation-test/ose-metallb-operator-bundle-container-v4.10.0.202302072301.p0.g186cf6b.assembly.stream-1/0898ccd9-df79-487e-aeee-d2cd44ebfe97/operator-metadata-linting-bundle-image-output.txt
gchat thread https://chat.google.com/room/AAAAZrx3KlI/qz4dtG_kSRw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants