Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-11824: Add the "support disconnected" infrastructure annotation #167

Conversation

fedepaol
Copy link
Member

@fedepaol fedepaol commented Jun 7, 2023

As per the official docs, we add the annotation so it's documented that metallb can be mirrored.

https://docs.openshift.com/container-platform/4.11/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-manual-annotations_osdk-generating-csvs

As per the official docs, we add the annotation so it's documented that
metallb can be mirrored.

https://docs.openshift.com/container-platform/4.11/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-manual-annotations_osdk-generating-csvs

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 7, 2023
@openshift-ci-robot
Copy link

@fedepaol: This pull request references Jira Issue OCPBUGS-11824, which is invalid:

  • expected the bug to target the "4.13.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-11824 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

As per the official docs, we add the annotation so it's documented that metallb can be mirrored.

https://docs.openshift.com/container-platform/4.11/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-manual-annotations_osdk-generating-csvs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fedepaol
Copy link
Member Author

fedepaol commented Jun 7, 2023

/jira refresh

@openshift-ci-robot
Copy link

@fedepaol: This pull request references Jira Issue OCPBUGS-11824, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2023
@fedepaol
Copy link
Member Author

fedepaol commented Jun 7, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 7, 2023
@openshift-ci-robot
Copy link

@fedepaol: This pull request references Jira Issue OCPBUGS-11824, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-10854 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-10854 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @asood-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from asood-rh June 7, 2023 08:58
@fedepaol
Copy link
Member Author

fedepaol commented Jun 7, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 7, 2023
@liornoy
Copy link

liornoy commented Jun 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2023
@asood-rh
Copy link

asood-rh commented Jun 7, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 7, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fde8dc5 and 2 for PR HEAD 9220d14 in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fde8dc5 and 2 for PR HEAD 9220d14 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fde8dc5 and 2 for PR HEAD 9220d14 in total

@fedepaol
Copy link
Member Author

/override ci/prow/ci-index-upgrade-bundle

@openshift-ci
Copy link

openshift-ci bot commented Jun 12, 2023

@fedepaol: Overrode contexts on behalf of fedepaol: ci/prow/ci-index-upgrade-bundle

In response to this:

/override ci/prow/ci-index-upgrade-bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fedepaol
Copy link
Member Author

/override ci/prow/ci-index-upgrade-bundle

@openshift-ci
Copy link

openshift-ci bot commented Jun 12, 2023

@fedepaol: Overrode contexts on behalf of fedepaol: ci/prow/ci-index-upgrade-bundle

In response to this:

/override ci/prow/ci-index-upgrade-bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fedepaol
Copy link
Member Author

/override ci/prow/operator-e2e-upgrade

@openshift-ci
Copy link

openshift-ci bot commented Jun 12, 2023

@fedepaol: Overrode contexts on behalf of fedepaol: ci/prow/operator-e2e-upgrade

In response to this:

/override ci/prow/operator-e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 12, 2023

@fedepaol: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d064b02 into openshift:release-4.13 Jun 12, 2023
8 checks passed
@openshift-ci-robot
Copy link

@fedepaol: Jira Issue OCPBUGS-11824: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11824 has been moved to the MODIFIED state.

In response to this:

As per the official docs, we add the annotation so it's documented that metallb can be mirrored.

https://docs.openshift.com/container-platform/4.11/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-manual-annotations_osdk-generating-csvs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants