-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-18838: Backport liveness 4.12 #187
OCPBUGS-18838: Backport liveness 4.12 #187
Conversation
Align to 0.13.7 Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
This includes service and namespace selection support for ip address pools. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
Bumping metallb again, consuming the version where we wrap the liveness probe execution behind http. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
depends on openshift/metallb#140 - |
@oribon: This pull request references Jira Issue OCPBUGS-18838, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@oribon: This pull request references Jira Issue OCPBUGS-18838, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@oribon: This pull request references Jira Issue OCPBUGS-18838, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@oribon: This pull request references Jira Issue OCPBUGS-18838, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@oribon: This pull request references Jira Issue OCPBUGS-18838, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
2 similar comments
/retest |
/retest |
/override ci/prow/metallb-e2e-metal-ipi-ovn |
/override ci/prow/ci-index-upgrade-bundle |
/approve |
@fedepaol: Overrode contexts on behalf of fedepaol: ci/prow/metallb-e2e-metal-ipi-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label backport-risk-assessed |
@oribon: This pull request references Jira Issue OCPBUGS-18838, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fedepaol: Overrode contexts on behalf of fedepaol: ci/prow/ci-index-upgrade-bundle In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@oribon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fedepaol, oribon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/label cherry-pick-approved |
@oribon: Jira Issue OCPBUGS-18838: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-18838 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cherry-pick of the relevant commits to bring the liveness probe to 4.12,
the second was not clean, had to manually accept commit refs on
.github/workflows/metallb_e2e.yml
andhack/common.sh
depends on openshift/metallb#140 - operator-e2e fails locally using quay.io/openshift/origin-metallb:4.12, passes using a custom build of openshift/metallb#140 (the livez endpoint is missing from 4.12)