Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] OCPBUGS-35864: D/S CSV: override the frr-k8s image #229

Merged
merged 1 commit into from
Jul 13, 2024
Merged

[release-4.16] OCPBUGS-35864: D/S CSV: override the frr-k8s image #229

merged 1 commit into from
Jul 13, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #226

/assign fedepaol

@fedepaol
D/S CSV: override the frr-k8s image
f1e6ed0 
The operator is currently pulling the upstream FRR-K8s image while it
should consume the d/s one.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 20, 2024
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35754 has been cloned as Jira Issue OCPBUGS-35864. Will retitle bug to link to clone.
/retitle [release-4.16] OCPBUGS-35864: D/S CSV: override the frr-k8s image

In response to this:

This is an automated cherry-pick of #226

/assign fedepaol

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.16] OCPBUGS-35754: D/S CSV: override the frr-k8s image [release-4.16] OCPBUGS-35864: D/S CSV: override the frr-k8s image Jun 20, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 20, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35864, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-35754 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-35754 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @asood-rh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #226

/assign fedepaol

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@karampok
Copy link

/retest-required

@fedepaol fedepaol mentioned this pull request Jul 12, 2024
Merged
@asood-rh
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 12, 2024
@fedepaol
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 12, 2024
@fedepaol
Copy link
Member

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 12, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fedepaol
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b9a71bb into openshift:release-4.16 Jul 13, 2024
7 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35864: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35864 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #226

/assign fedepaol

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-metallb-operator-container-v4.16.0-202407131906.p0.gb9a71bb.assembly.stream.el9 for distgit ose-metallb-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asood-rh asood-rh Awaiting requested review from asood-rh

@dougbtv dougbtv Awaiting requested review from dougbtv

@msherif1234 msherif1234 Awaiting requested review from msherif1234

Assignees

@fedepaol fedepaol

@asood-rh asood-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @karampok @asood-rh @fedepaol @openshift-bot