Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2104669: Check that deployment ready replicas greater than zero #89

Conversation

cgoncalves
Copy link

There is a case where both ReadyReplicas and Replicas are 0
and the Eventually passes. Adding this to avoid this situation.

There is a case where both ReadyReplicas and Replicas are 0
and the Eventually passes. Adding this to avoid this situation.

Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
(cherry picked from commit d6723b4)
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2022

@cgoncalves: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Check that deployment ready replicas greater than zero

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from fedepaol and russellb June 8, 2022 07:34
@cgoncalves cgoncalves changed the title Check that deployment ready replicas greater than zero Bug 2068600: Check that deployment ready replicas greater than zero Jun 8, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2022

@cgoncalves: This pull request references Bugzilla bug 2068600, which is invalid:

  • expected the bug to target the "4.9.z" release, but it targets "---" instead
  • expected Bugzilla bug 2068600 to depend on a bug targeting a release in 4.10.0, 4.10.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2068600: Check that deployment ready replicas greater than zero

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgoncalves
Copy link
Author

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2022

@cgoncalves: This pull request references Bugzilla bug 2068600, which is invalid:

  • expected Bugzilla bug 2068600 to depend on a bug targeting a release in 4.10.0, 4.10.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgoncalves
Copy link
Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2022

@cgoncalves: This pull request references Bugzilla bug 2068600, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2094679 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2094679 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (nkononov@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2022

@cgoncalves: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fedepaol
Copy link
Member

/approve
/labe backport-risk-assessed

@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgoncalves, fedepaol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fedepaol
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2022
@fedepaol
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 22, 2022
@cgoncalves cgoncalves changed the title Bug 2068600: Check that deployment ready replicas greater than zero Bug 2104669: Check that deployment ready replicas greater than zero Jul 7, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2022

@cgoncalves: This pull request references Bugzilla bug 2104669, which is invalid:

  • expected the bug to target the "4.9.z" release, but it targets "---" instead
  • expected Bugzilla bug 2104669 to depend on a bug targeting a release in 4.10.0, 4.10.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2104669: Check that deployment ready replicas greater than zero

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgoncalves
Copy link
Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2022

@cgoncalves: This pull request references Bugzilla bug 2104669, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2094679 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2094679 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (nkononov@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fedepaol
Copy link
Member

fedepaol commented Jul 7, 2022

/label cherry-pick approved

@fedepaol
Copy link
Member

fedepaol commented Jul 7, 2022

/label cherry-pick-approved

@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2022

@fedepaol: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgoncalves
Copy link
Author

@asood-rh @gregkopels @evgenLevin could one of you please review and approve the cherry-pick? Thank you.

@asood-rh
Copy link

asood-rh commented Jul 7, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 7, 2022
@openshift-ci openshift-ci bot merged commit 00b30ff into openshift:release-4.9 Jul 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2022

@cgoncalves: All pull requests linked via external trackers have merged:

Bugzilla bug 2104669 has been moved to the MODIFIED state.

In response to this:

Bug 2104669: Check that deployment ready replicas greater than zero

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants