Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.11] Bug 2115812: Add validation webhook for L2Advertisement #79

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #72

/assign fedepaol

The validation webook is currently missing for l2 adv
object, this commit ensures such validating webhook
implmented for it.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
(cherry picked from commit 240aed9)
@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2022

@openshift-cherrypick-robot: Bugzilla bug 2100845 has been cloned as Bugzilla bug 2115812. Retitling PR to link against new bug.
/retitle [release-4.11] Bug 2115812: Add validation webhook for L2Advertisement

In response to this:

[release-4.11] Bug 2100845: Add validation webhook for L2Advertisement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.11] Bug 2100845: Add validation webhook for L2Advertisement [release-4.11] Bug 2115812: Add validation webhook for L2Advertisement Aug 5, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 5, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2115812, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2100845 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2100845 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @asood-rh

In response to this:

[release-4.11] Bug 2115812: Add validation webhook for L2Advertisement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fedepaol
Copy link
Member

fedepaol commented Aug 5, 2022

/approve
/lgtm
/label cherry-pick-approved

@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2022

@fedepaol: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/approve
/lgtm
/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
@msherif1234
Copy link

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 15, 2022
@asood-rh
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 15, 2022
@openshift-merge-robot openshift-merge-robot merged commit 0bd1c40 into openshift:release-4.11 Aug 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2115812 has been moved to the MODIFIED state.

In response to this:

[release-4.11] Bug 2115812: Add validation webhook for L2Advertisement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants