OCPBUGS-1227: Skip unnecessary node events in config reconciler #87
Conversation
The config controller watches node event to populate l2 and bgp advertisement objects with selected nodes based on node selector labels. But currently a change in the node results in reprocessing the configuration, which results in reprocessing the services. This results in an unnecessary cpu load. Hence this change skips processing unnecessary node events other than node create, node update (if its with new labels) and node delete events. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com> (cherry picked from commit 2f2ff0d)
openshift-ci-robot
added
jira/severity-moderate
|
@pperiyasamy: This pull request references Jira Issue OCPBUGS-1227, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@pperiyasamy: This pull request references Jira Issue OCPBUGS-1227, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@pperiyasamy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fedepaol, pperiyasamy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@pperiyasamy: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-1227 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The config controller watches node event to populate l2 and bgp advertisement objects with selected nodes based on node selector labels.
But currently a change in the node results in reprocessing the configuration, which results in reprocessing the services. This results in an unnecessary cpu load.
Hence this change skips processing unnecessary node events other than node create, node update (if its with new labels) and node delete events.
Signed-off-by: Periyasamy Palanisamy pepalani@redhat.com
(cherry picked from commit 2f2ff0d)