Skip to content

Commit

Permalink
USHIFT-1030: add verify-py.sh
Browse files Browse the repository at this point in the history
  • Loading branch information
chiragkyal committed Apr 9, 2023
1 parent 16a9db3 commit b84f3e6
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 5 deletions.
6 changes: 1 addition & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,7 @@ verify-sh:

.PHONY: verify-py
verify-py:
python3 -m venv /tmp/venv ;
/tmp/venv/bin/python3 -m pip install --upgrade pip ;
/tmp/venv/bin/python3 -m pip install -r requirements.txt ;
/tmp/venv/bin/pylint --variable-naming-style=any \
$$(find . -type d \( -path ./_output -o -path ./vendor -o -path ./assets -o -path ./etcd/vendor \) -prune -o -name '*.py' -print)
./hack/verify-py.sh

###############################
# post install validate #
Expand Down
27 changes: 27 additions & 0 deletions hack/verify-py.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
#!/bin/bash

set -euo pipefail

ROOTDIR=$(git rev-parse --show-toplevel)
REQ_FILE=${ROOTDIR}/requirements.txt
VENV="/tmp/venv"
PYLINT="pylint"

if ! command -v ${PYLINT} &>/dev/null; then

check="$(python3 -m pip install -r ${REQ_FILE} 2>&1 | grep 'Permission denied')"

# Install pylint in a virtual environment for CI
if [ ! -z "$check" ] ; then
printf "Installing pylint in '${VENV}' virtual environment"
python3 -m venv ${VENV}
${VENV}/bin/python3 -m pip install --upgrade pip
${VENV}/bin/python3 -m pip install -r ${REQ_FILE}
PYLINT="/tmp/venv/bin/pylint"
fi
fi

PYFILES=$(find . -type d \( -path ./_output -o -path ./vendor -o -path ./assets -o -path ./etcd/vendor \) -prune -o -name '*.py' -print)
printf "Running ${PYLINT} for \n${PYFILES}\n"

${PYLINT} --variable-naming-style=any ${PYFILES}

0 comments on commit b84f3e6

Please sign in to comment.