Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] USHIFT-657 MicroShift does not find lvmd config if no microshift config file exists. #1160

Merged

Conversation

copejon
Copy link
Contributor

@copejon copejon commented Dec 1, 2022

Which issue(s) this PR addresses:

Closes # USHIFT-657

This PR removes the assumption that the microshift config and the lvmd config are always co-located. This created a situation where, if a user does not create a microshift config, the search for the lvmd config would short circuit. This isn't a safe assumption because the microshift default values, used when a user hasn't created a config file, are generally safe for common use cases. The lvmd config however must usually be defined to describe the host's storage environment, which is probably less uniform with arbitrary volume group names.

This became and issue when the name of the microshift default/example config was changed in the RPM spec, which provided an anchor for the lvmd config logic to rely on when no user config was specified.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2022
@copejon
Copy link
Contributor Author

copejon commented Dec 1, 2022

I'm unable to access the jira board at the moment. Will try again tomorrow and append the ticket link asap.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2022
@copejon
Copy link
Contributor Author

copejon commented Dec 1, 2022

/bug
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2022
pkg/components/storage.go Outdated Show resolved Hide resolved
@pmtk
Copy link
Member

pmtk commented Dec 2, 2022

/retest-required

@copejon
Copy link
Contributor Author

copejon commented Dec 2, 2022

pre-steps are failing during system dep installs
/retest

@pmtk
Copy link
Member

pmtk commented Dec 3, 2022

/retest

@copejon
Copy link
Contributor Author

copejon commented Dec 5, 2022

/bug

@copejon copejon changed the title [WIP] [BUG] If microshift config file doesn't exist, lvmd file is ignored [BUG] If microshift config file doesn't exist, lvmd file is ignored Dec 5, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2022
@copejon copejon added the kind/bug Categorizes issue or PR as related to a bug. label Dec 5, 2022
@copejon copejon changed the title [BUG] If microshift config file doesn't exist, lvmd file is ignored [BUG] USHIFT-657 If microshift config file doesn't exist, lvmd file is ignored Dec 5, 2022
@copejon copejon changed the title [BUG] USHIFT-657 If microshift config file doesn't exist, lvmd file is ignored [BUG] USHIFT-657 MicroShift does not find lvmd config if no microshift config file exists. Dec 5, 2022
pkg/components/storage.go Outdated Show resolved Hide resolved
Co-authored-by: Patryk Matuszak <305846+pmtk@users.noreply.github.com>
@copejon
Copy link
Contributor Author

copejon commented Dec 6, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2022
@pmtk
Copy link
Member

pmtk commented Dec 6, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2022

@copejon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-router-smoke-test 1294a83 link false /test e2e-router-smoke-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit cb7f9bb into openshift:main Dec 6, 2022
@copejon copejon deleted the lvmd-config-search-fix branch December 6, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants