-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] USHIFT-657 MicroShift does not find lvmd config if no microshift config file exists. #1160
[BUG] USHIFT-657 MicroShift does not find lvmd config if no microshift config file exists. #1160
Conversation
I'm unable to access the jira board at the moment. Will try again tomorrow and append the ticket link asap. |
/bug |
/retest-required |
pre-steps are failing during system dep installs |
/retest |
/bug |
…e assuming default.
23f280f
to
59dca94
Compare
59dca94
to
61cc979
Compare
Co-authored-by: Patryk Matuszak <305846+pmtk@users.noreply.github.com>
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@copejon: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Which issue(s) this PR addresses:
Closes # USHIFT-657
This PR removes the assumption that the microshift config and the lvmd config are always co-located. This created a situation where, if a user does not create a microshift config, the search for the lvmd config would short circuit. This isn't a safe assumption because the microshift default values, used when a user hasn't created a config file, are generally safe for common use cases. The lvmd config however must usually be defined to describe the host's storage environment, which is probably less uniform with arbitrary volume group names.
This became and issue when the name of the microshift default/example config was changed in the RPM spec, which provided an anchor for the lvmd config logic to rely on when no user config was specified.