Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase-4.12.0-0.nightly-2022-12-09-063749 #1183

Closed

Conversation

microshift-rebase-script[bot]
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from oglok and sallyom December 10, 2022 05:20
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: microshift-rebase-script[bot]
Once this PR has been reviewed and has the lgtm label, please assign fzdarsky for approval by writing /assign @fzdarsky in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2022

Hi @microshift-rebase-script[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2022
@ggiguash
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2022

@microshift-rebase-script[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-router-smoke-test ca7b152 link false /test e2e-router-smoke-test
ci/prow/e2e-openshift-conformance-sig-arch ca7b152 link true /test e2e-openshift-conformance-sig-arch
ci/prow/e2e-rpm-install ca7b152 link true /test e2e-rpm-install
ci/prow/e2e-openshift-conformance-sig-cli ca7b152 link true /test e2e-openshift-conformance-sig-cli
ci/prow/e2e-openshift-conformance-sig-scheduling ca7b152 link true /test e2e-openshift-conformance-sig-scheduling
ci/prow/e2e-reboot ca7b152 link true /test e2e-reboot
ci/prow/e2e-openshift-conformance-sig-apps ca7b152 link true /test e2e-openshift-conformance-sig-apps
ci/prow/e2e-openshift-conformance-sig-instrumentation ca7b152 link true /test e2e-openshift-conformance-sig-instrumentation
ci/prow/e2e-openshift-conformance-sig-network ca7b152 link true /test e2e-openshift-conformance-sig-network
ci/prow/e2e-openshift-conformance-sig-auth ca7b152 link true /test e2e-openshift-conformance-sig-auth
ci/prow/e2e-openshift-conformance-sig-node ca7b152 link true /test e2e-openshift-conformance-sig-node
ci/prow/e2e-openshift-conformance-sig-api-machinery ca7b152 link true /test e2e-openshift-conformance-sig-api-machinery
ci/prow/e2e-openshift-conformance-sig-storage ca7b152 link true /test e2e-openshift-conformance-sig-storage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fzdarsky
Copy link
Contributor

#1176 missed to update the rebase script, so this change is not correct.

@fzdarsky fzdarsky closed this Dec 11, 2022
@pmtk
Copy link
Member

pmtk commented Dec 13, 2022

/reopen

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2022

@pmtk: Failed to re-open PR: state cannot be changed. The rebase-4.12.0-0.nightly-2022-12-09-063749 branch was force-pushed or recreated.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk
Copy link
Member

pmtk commented Dec 13, 2022

Huh, interesting.
There was no new nightly releases, so rebase job is still running daily with that from 9th Dec.
Because we merged new changes to our main what script was trying to do is: use the same nightly build but on newer main, so it detects that this PR is "out of date" and force pushes new changes, but because the PR exists it was not reopened, and because it was closed when new changes came in openshift-ci-bot doesn't want to reopen it.
Created USHIFT-679 to handle this situation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants