-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-677: Remove _output on successful rebase #1191
USHIFT-677: Remove _output on successful rebase #1191
Conversation
@pmtk: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -691,6 +691,9 @@ rebase_to() { | |||
else | |||
echo "No changes to buildfiles." | |||
fi | |||
|
|||
title "# Removing staging directory" | |||
rm -rf "$REPOROOT/_output" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean the directory is only cleaned up in the full "to" workflow? But if a developer uses the individual commands to fetch images, update manifests, etc. then the temporary directory is not cleaned up? I think that's what we want, but I want to make sure I understand the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. And if anything along the way fails, script won't reach the removal, so (I hope) this addition won't be an annoyance for devs, but will address source RPM issue on our side rather than ART's.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.