Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] NOISSUE: look up rebase version and date in the image if needed #1294

Merged
merged 1 commit into from
Jan 26, 2023
Merged

[release-4.12] NOISSUE: look up rebase version and date in the image if needed #1294

merged 1 commit into from
Jan 26, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1272

/assign pmtk

@dhellmann
rebase: look up version and date in the image if needed
7886cdf 
By default we use version and date information from the image pull
spec. If that information is not available, fall back to looking
inside the release info file. This allows rebasing onto public
versions using pullspecs like
quay.io/openshift-release-dev/ocp-release:4.12.0-x86_64
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 26, 2023
Merged
@pmtk
Copy link
Member

pmtk commented Jan 26, 2023

/lgtm
/label backport-risk-assessed
/label bugzilla/valid-bug

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 26, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2023
@jogeo
Copy link
Contributor

jogeo commented Jan 26, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3db9e81 into openshift:release-4.12 Jan 26, 2023
@dhellmann
Copy link
Contributor

dhellmann commented Jan 26, 2023 •
edited by openshift-ci bot

Retroactively linking to USHIFT-792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluddy benluddy Awaiting requested review from benluddy

@copejon copejon Awaiting requested review from copejon

Assignees

@pmtk pmtk

@mffiedler mffiedler

@jhou1 jhou1

@zhaozhanqi zhaozhanqi

@jogeo jogeo

@xingxingxia xingxingxia

@anuragthehatter anuragthehatter

@wangke19 wangke19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet