USHIFT-907: Remove unsupported topolvm manifests #1397
Conversation
|
/pj-rehearse ack |
openshift-ci
bot
added
the
approved
|
/pj-rehearse |
|
/pj-rehearse ack |
|
/pj-rehearse |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
/retest-required |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
Could you add a little detail to the description and/or commit message explaining why we don't want these files? There are 7 commits in the PR. Are the all independent, or can they be squashed into fewer? |
|
Hey @dhellmann, np. I've updated the description. |
dhellmann
added
the
kind/cleanup
|
@pmtk or @pacevedom , we could set the merge method to squash this as it lands, if we want to get it in this week. What do you think? |
dhellmann
changed the title
|
@copejon: This pull request references USHIFT-907 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
copejon
force-pushed
the
ushift-907
branch
2 times, most recently
from
3e11cd3
to
b2913b5
Compare
remove resizer manifests from storage starter testing kuttl timeout values, may be too aggressive for cluster start time (30s) re-delete file added by rebase remove assets that are not stored in assets/components/lvms update assets.yaml remove unsupported topolvm manifests
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon, dhellmann The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@copejon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Which issue(s) this PR addresses:
This change removes files that contain the rbac / scc configuration for topolvm workloads (resizer, snapshotter) that are not shipped on MicroShift by default. As such, they don't enable or impede existing MicroShift components. Removing them is simply a housecleaning task.
Closes #USHIFT-907