[release-4.13] OCPBUGS-10242: make lvms configuration more robust #1530
Conversation
Instead of requiring the user to configure their system with a "rhel" volume group, look at the volume groups that exist and apply some selection rules: * If there is a "rhel" VG, use it. * If there is only one VG, use it. * Otherwise, disable the CSI driver with a log message.
When there are multiple volume groups, look for one named "microshift" to use, instead of "rhel".
Include a message in the body of the file added to the config map to explain where the content came from.
|
@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-9996 with correct target version. Will retitle the PR to link to the clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-10242, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. Retaining the bugzilla/valid-bug label as it was manually added. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned anuragthehatter, jhou1, jogeo, mffiedler, pacevedom, wangke19, xingxingxia and zhaozhanqi
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Update the description of the logic to match the changes for OCPBUGS-10242 in openshift/microshift#1530 Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Update the description of the logic to match the changes for OCPBUGS-10242 in openshift/microshift#1530 Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Update the description of the logic to match the changes for OCPBUGS-10242 in openshift/microshift#1530 Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
merged commit bd6fb96
into
openshift:release-4.13
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-10242: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-10242 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update the description of the logic to match the changes for OCPBUGS-10242 in openshift/microshift#1530 Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Update the description of the logic to match the changes for OCPBUGS-10242 in openshift/microshift#1530 clean up syntax of command for using LVMS Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Update the description of the logic to match the changes for OCPBUGS-10242 in openshift/microshift#1530 clean up syntax of command for using LVMS Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Update the description of the logic to match the changes for OCPBUGS-10242 in openshift/microshift#1530 clean up syntax of command for using LVMS Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Update the description of the logic to match the changes for OCPBUGS-10242 in openshift/microshift#1530 clean up syntax of command for using LVMS Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
This is an automated cherry-pick of #1489
/assign dhellmann