USHIFT-642: Static analysis for .go, .sh, and .py

[pmtk]

No description provided.

[openshift-ci-robot]

@pmtk: This pull request references USHIFT-642 which is a valid jira issue.

In response to this:

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@pmtk: GitHub didn't allow me to request PR reviews from the following users: pmtk.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@pmtk: This pull request references USHIFT-642 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pmtk]

/test e2e-openshift-conformance-reduced-arm

[pmtk]

/test e2e-router-smoke-test

[dhellmann]

This looks OK. It would be nice if the tools could be run by a developer using a container image, but I suppose that wouldn't work well in CI where the job is already running in a container?

[pmtk]

This looks OK. It would be nice if the tools could be run by a developer using a container image, but I suppose that wouldn't work well in CI where the job is already running in a container?

Not sure about running container within a job - by glancing https://www.redhat.com/sysadmin/podman-inside-kubernetes it might need some extra privileges that CI probably don't support.
Other way would be to use that container with tools as a base and copy sources into it, e.g.:

    FROM linter-tools
    COPY microshift /tmp/
    WORKDIR /tmp/microshift/

then in a job: cd /tmp/microshift && make lint-xyz - we'd have to find a way to keep this straightforward for dev as well: make lint would start a container with sources mounted (just like rpm-podman).

[ggiguash]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ggiguash,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pmtk]

/test e2e-openshift-conformance-reduced

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 3b55dbd and 2 for PR HEAD 2b06325 in total

[openshift-ci]

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dhellmann]

2b06325 also resolves USHIFT-987