[release-4.13] USHIFT-1016: microshift crashes if LVM is not supported by host #1597
Conversation
|
@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug USHIFT-1016 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":["Number value expected as the Sprint id."],"errors":{}}
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
openshift-ci
bot
added
the
approved
|
/lgtm |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned anuragthehatter, jhou1, jogeo, mffiedler, pacevedom, wangke19, xingxingxia, zhaozhanqi and dhellmann
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon, dhellmann, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM, verified the resolution works: System: Ran: # remove lvm
$ sudo dnf remove lvm2* -y
$ make clean rpm srpm
$ sudo dnf localinstall -y ~/microshift/_output/rpmbuild/RPMS/*/*.rpm
# make sure error get's printed
$ sudo journalctl -u microshift.service | grep "failed to find 'vgs' command line tool"
....
Mar 30 19:30:36 microshift-instance-9.local microshift[160573]: infrastructure-services-manager W0330 19:30:36.458260 160573 storage.go:75] skipping CSI deployment: %vfailed to find 'vgs' command line tool: exec: "vgs": executable file not found in $PATH
# check to make sure storage ns isn't created
$ oc get ns
NAME STATUS AGE
default Active 11m
kube-node-lease Active 11m
kube-public Active 11m
kube-system Active 11m
openshift-dns Active 11m
openshift-infra Active 11m
openshift-ingress Active 11m
openshift-kube-controller-manager Active 11m
openshift-ovn-kubernetes Active 11m
openshift-route-controller-manager Active 11m
openshift-service-ca Active 11m
# re-install lvm and restart microshift
$ sudo dnf install lvm2* -y && sudo systemctl restart microshift
# check storage namespace has been created
$ oc get ns
NAME STATUS AGE
default Active 13m
kube-node-lease Active 13m
kube-public Active 13m
kube-system Active 13m
openshift-dns Active 12m
openshift-infra Active 12m
openshift-ingress Active 12m
openshift-kube-controller-manager Active 12m
openshift-ovn-kubernetes Active 12m
openshift-route-controller-manager Active 12m
openshift-service-ca Active 12m
openshift-storage Active 8s ### Created |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-reference
|
@eggfoobar: This pull request references USHIFT-1016 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
| @@ -75,6 +75,11 @@ func startCSIPlugin(cfg *config.MicroshiftConfig, kubeconfigPath string) error { | |||
| } | |||
| ) | |||
|
|
|||
| if err := lvmd.LvmSupported(); err != nil { | |||
| klog.Warning("skipping CSI deployment: %v", err) | |||
There was a problem hiding this comment.
Nothing to hold this PR if we don't want to touch it, but it's missing f: klog.Warningf so the log looks like:
skipping CSI deployment: %vfailed to find 'vgs' command line tool: exec: "vgs": executable file not found in $PATH
I'd say we could leave it as is in 4.13 and make a small fix in main (or even just fix it when touching this file in another PR)
There was a problem hiding this comment.
Yeah, Jon caught that and fixed it in this PR, #1598 seems the bot didn't pick up his cherry pick.
There was a problem hiding this comment.
Well it didn't pick it up because the timing is off, this needs to go in first before we can cherry-pick that one
There was a problem hiding this comment.
Yeah, i'll have that backported rather than fix the the bot-generated PR.
|
/label bugzilla/valid-bug |
|
@eggfoobar: Can not set label bugzilla/valid-bug: Must be member in one of these teams: [] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label bugzilla/valid-bug |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #1577
/assign copejon