New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-1050: Set textrel_shlib_t SELinux context on hadolint static executable #1655
USHIFT-1050: Set textrel_shlib_t SELinux context on hadolint static executable #1655
Conversation
@ggiguash: This pull request references USHIFT-1050 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@ggiguash: This pull request references USHIFT-1050 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @chiragkyal |
…the global scope and rename it to WORK_DIR
426f549
to
e3c0233
Compare
It's LGTM for me. Let's have someone more to review. |
# that are not labeled textrel_shlib_t, then you must tell SELinux about this by enabling the | ||
# 'selinuxuser_execmod' boolean. | ||
if selinuxenabled ; then | ||
chcon -t textrel_shlib_t "${DEST_DIR}/${filename}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we only need to do this for hadolint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because, it's the "only" statically linked binary we have and loader / SELinux treat it differently.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ggiguash: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
textrel_shlib_t
SELinux context to preventhadolint
crash.tmp
variable in the global scope and rename it toWORK_DIR
Closes USHIFT-1050
Context
hadolint
executable is statically linked and it causes the following errors on some systems when SELinux is enabled.