Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-13078: Remove config flag externalGatewayInterface from ovn.yaml #1729

Merged
merged 1 commit into from
May 9, 2023

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Apr 28, 2023

This flag is for building a secondary bridge br-ex1 for OVN-K. The br-ex1 bridge is used by the multiple external gateway feature that we don't support in microshift.

This flag is for building a secondary bridge br-ex1 for OVN-K.
The br-ex1 bridge is used by the multiple external gateway feature
that we don't support in microshift.

Signed-off-by: Peng Liu <pliu@redhat.com>
@openshift-ci openshift-ci bot requested review from dhellmann and pmtk April 28, 2023 11:57
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2023
@pliurh pliurh changed the title Remove config flag externalGatewayInterface from ovn.yaml NO-ISSUE: Remove config flag externalGatewayInterface from ovn.yaml Apr 28, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 28, 2023
@openshift-ci-robot
Copy link

@pliurh: This pull request explicitly references no jira issue.

In response to this:

This flag is for building a secondary bridge br-ex1 for OVN-K. The br-ex1 bridge is used by the multiple external gateway feature that we don't support in microshift.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pliurh
Copy link
Contributor Author

pliurh commented Apr 28, 2023

/retest

@dhellmann
Copy link
Contributor

CI is currently broken for reasons unrelated to this PR.

While we wait for the team to fix that, please open a ticket in Jira and link this PR to it so we can track the change and make sure we create a release note for it.

@dhellmann
Copy link
Contributor

/retest

@pliurh pliurh changed the title NO-ISSUE: Remove config flag externalGatewayInterface from ovn.yaml OCPBUGS-13078: Remove config flag externalGatewayInterface from ovn.yaml May 4, 2023
@openshift-ci-robot openshift-ci-robot added the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label May 4, 2023
@openshift-ci-robot
Copy link

@pliurh: This pull request references Jira Issue OCPBUGS-13078, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This flag is for building a secondary bridge br-ex1 for OVN-K. The br-ex1 bridge is used by the multiple external gateway feature that we don't support in microshift.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 4, 2023
@pliurh
Copy link
Contributor Author

pliurh commented May 4, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 4, 2023
@openshift-ci-robot
Copy link

@pliurh: This pull request references Jira Issue OCPBUGS-13078, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jogeo May 4, 2023 03:13
@pliurh
Copy link
Contributor Author

pliurh commented May 4, 2023

/retest

@zshi-redhat
Copy link
Contributor

@pliurh could you also remove the externalGatewayInterface from ./packaging/systemd/configure-ovs.sh? This script reads the ovn.yaml and configure the br-ex if externalGatewayInterface is specified.

@dhellmann
Copy link
Contributor

This setting appears in the user documentation, too, so please coordinate with @ShaunaDiaz to make sure that information is updated or removed.

$ git grep externalGatewayInterface
modules/microshift-cni.adoc:* The `externalGatewayInterface` is not specified in the `ovn.yaml` config file.
modules/microshift-cni.adoc:* The `externalGatewayInterface` is user-specified in the `ovn.yaml` config file.
modules/microshift-configuring-ovn.adoc:  externalGatewayInterface: "" <2>
modules/microshift-configuring-ovn.adoc:|`ovsInit.externalGatewayInterface`
modules/microshift-configuring-ovn.adoc:  externalGatewayInterface: eth1

@pliurh
Copy link
Contributor Author

pliurh commented May 9, 2023

could you also remove the externalGatewayInterface from ./packaging/systemd/configure-ovs.sh?

The script's logic can also help remove the br-ex1 bridge if externalGatewayInterface is undefined. So we shall keep it for the upgrade scenario.

@pliurh
Copy link
Contributor Author

pliurh commented May 9, 2023

/retest

@zshi-redhat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pliurh, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zshi-redhat
Copy link
Contributor

/test e2e-openshift-conformance-reduced-arm

@openshift-merge-robot openshift-merge-robot merged commit 88053cb into openshift:main May 9, 2023
8 of 9 checks passed
@openshift-ci-robot
Copy link

@pliurh: Jira Issue OCPBUGS-13078: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13078 has been moved to the MODIFIED state.

In response to this:

This flag is for building a secondary bridge br-ex1 for OVN-K. The br-ex1 bridge is used by the multiple external gateway feature that we don't support in microshift.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2023

@pliurh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm e5a7414 link false /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pliurh
Copy link
Contributor Author

pliurh commented Jun 13, 2023

/cherrypick release-4.13

@openshift-cherrypick-robot

@pliurh: new pull request created: #1922

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants