New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-1102: add static manifest details for running openshift-tests #1969
Conversation
@chiragkyal: This pull request references USHIFT-1102 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @dhellmann @ggiguash |
docs/openshift_ci.md
Outdated
|
||
Currently only manifests from `[infrastructure|network].config.openshift.io/v1` are supported as static manifests. | ||
|
||
Exemplary manifests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these manifests are required for the normal test runtime, can we make the yaml snapshots into commands to create the files? Something like the following:
MICROSHIFT_URL=<microshift-server-url>
cat > ${STATIC_CONFIG_MANIFEST_DIR}/single-replica.yaml <<EOF
...
...
status:
apiServerURL: ${MICROSHIFT_URL}
...
EOF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. Added.
@chiragkyal: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chiragkyal, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add documentation for applying static manifests before running openshift-tests.
The implementation details are here.