Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-1102: add static manifest details for running openshift-tests #1969

Merged
merged 1 commit into from Jun 28, 2023

Conversation

chiragkyal
Copy link
Member

Add documentation for applying static manifests before running openshift-tests.
The implementation details are here.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2023

@chiragkyal: This pull request references USHIFT-1102 which is a valid jira issue.

In response to this:

Add documentation for applying static manifests before running openshift-tests.
The implementation details are here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from pacevedom and pliurh June 28, 2023 06:59
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@chiragkyal
Copy link
Member Author

/cc @dhellmann @ggiguash


Currently only manifests from `[infrastructure|network].config.openshift.io/v1` are supported as static manifests.

Exemplary manifests:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these manifests are required for the normal test runtime, can we make the yaml snapshots into commands to create the files? Something like the following:

MICROSHIFT_URL=<microshift-server-url>
cat > ${STATIC_CONFIG_MANIFEST_DIR}/single-replica.yaml <<EOF
...
...
status:
  apiServerURL: ${MICROSHIFT_URL}
...
EOF


Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. Added.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023

@chiragkyal: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chiragkyal, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chiragkyal,ggiguash]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 604b497 into openshift:main Jun 28, 2023
4 checks passed
@chiragkyal chiragkyal deleted the USHIFT-1102 branch June 28, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants