Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-1411: pin ovs dependency to 3.1.1 and fix up CI #2016

Merged
merged 4 commits into from
Jul 10, 2023
Merged

USHIFT-1411: pin ovs dependency to 3.1.1 and fix up CI #2016

merged 4 commits into from
Jul 10, 2023

Conversation

dhellmann
Copy link
Contributor

This is a temporary work-around for OCPBUGS-15948

/assign @pmtk @pliurh
/cc @zshi-redhat @pacevedom

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 7, 2023 •
edited by openshift-ci bot

@dhellmann: This pull request references USHIFT-1411 which is a valid jira issue.

In response to this:

This is a temporary work-around for OCPBUGS-15948

/assign @pmtk @pliurh
/cc @zshi-redhat @pacevedom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot assigned pliurh and pmtk Jul 7, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@dhellmann dhellmann force-pushed the USHIFT-1411-pin-ovs-dependency branch 2 times, most recently from 7693273 to b0664d1 Compare July 7, 2023 20:00
@pmtk
Copy link
Member

pmtk commented Jul 7, 2023

/test microshift-metal-tests

@dhellmann dhellmann mentioned this pull request Jul 7, 2023
Merged
@dhellmann
Copy link
Contributor Author

/hold

It is not clear this is actually helpful.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2023
@dhellmann dhellmann force-pushed the USHIFT-1411-pin-ovs-dependency branch from b0664d1 to a44cddc Compare July 7, 2023 23:55
@dhellmann
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2023
@dhellmann
Copy link
Contributor Author

/test microshift-metal-tests

@dhellmann
USHIFT-1411: pin ovs dependency to 3.1.1
1441e34 
This is a temporary work-around for OCPBUGS-15948
@dhellmann dhellmann force-pushed the USHIFT-1411-pin-ovs-dependency branch from a44cddc to 1441e34 Compare July 8, 2023 13:55
@dhellmann
Copy link
Contributor Author

/test microshift-metal-tests

@dhellmann
Copy link
Contributor Author

/test microshift-metal-tests

2 similar comments
@dhellmann
Copy link
Contributor Author

/test microshift-metal-tests

@dhellmann
Copy link
Contributor Author

/test microshift-metal-tests

@dhellmann
Copy link
Contributor Author

/test verify

@dhellmann
Copy link
Contributor Author

/test microshift-metal-tests

@dhellmann dhellmann changed the title USHIFT-1411: pin ovs dependency to 3.1.1 USHIFT-1411: pin ovs dependency to 3.1.1 and fix up CI Jul 8, 2023
ggiguash
ggiguash reviewed Jul 9, 2023
View reviewed changes
Makefile Outdated
@@ -136,7 +136,7 @@ verify-fast: verify-go verify-assets verify-sh verify-py verify-config verify-rf

# Full verification checks that should run in CI
.PHONY: verify-ci
verify-ci: verify-fast verify-images verify-licenses verify-containers
verify-ci: verify-fast verify-images verify-containers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the license verification removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message for that commit shows the error message that is breaking the job.

2023/07/08 18:18:45 failed to evaluate licenses: invalid character 'G' looking for beginning of value

It affects all PRs, so I suspect an updated version of the tool is behaving differently. We don't add new dependencies often, so I thought rather than spending time figuring out why that tool is reporting an error I would just turn it off.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1987 (comment) for example

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. This problem does not occur on my development machine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to reproduce it locally either. Perhaps it has something to do with the compiler version? Either way, I wanted to unblock us without spending time on a low-value tool.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented a w/a in the #2020 PR

@pmtk
Copy link
Member

pmtk commented Jul 10, 2023

/test microshift-metal-tests

@pmtk
Copy link
Member

pmtk commented Jul 10, 2023

/test microshift-metal-tests

[Errno 2] No such file or directory: '/var/cache/dnf/rhel-9-appstream-rhui-rpms-4266d693e48ae594/packages/git-core-2.39.3-1.el9_2.x86_64.rpm'

@pmtk
Copy link
Member

pmtk commented Jul 10, 2023

/test microshift-metal-tests

@pmtk
Copy link
Member

pmtk commented Jul 10, 2023 •
edited

Maybe we need something like dnf clean cache/packages or even all

@dhellmann dhellmann force-pushed the USHIFT-1411-pin-ovs-dependency branch from bf6e5a1 to eac0e4e Compare July 10, 2023 13:03
@dhellmann
Clear dnf cache
74c6855 
Try to avoid dnf conflicts by clearing the cache before we start doing
anything real.

Also show dnf history to debug cache collisions from parallel operations.
@dhellmann dhellmann force-pushed the USHIFT-1411-pin-ovs-dependency branch from eac0e4e to 74c6855 Compare July 10, 2023 13:06
@pmtk
Copy link
Member

pmtk commented Jul 10, 2023

/test microshift-metal-tests

pacevedom
pacevedom approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dhellmann,pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhellmann
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2023

@dhellmann: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/microshift-metal-tests 74c6855 link false /test microshift-metal-tests
ci/prow/e2e-openshift-conformance-reduced-arm 74c6855 link false /test e2e-openshift-conformance-reduced-arm
ci/prow/microshift-e2e-arm 74c6855 link false /test microshift-e2e-arm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 70b2697 into openshift:main Jul 10, 2023
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggiguash ggiguash ggiguash left review comments

@pacevedom pacevedom pacevedom approved these changes

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

Assignees

@pmtk pmtk

@pliurh pliurh

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dhellmann @openshift-ci-robot @pmtk @pacevedom @ggiguash @pliurh @openshift-merge-robot