Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-1436: capture composer logs when building images #2058

Merged
merged 3 commits into from
Jul 14, 2023
Merged

USHIFT-1436: capture composer logs when building images #2058

merged 3 commits into from
Jul 14, 2023

Conversation

dhellmann
Copy link
Contributor

Download the composer logs for all of the builds performed and stage them
with unique filenames so they can be collected by the CI system.

Remove the redundant log handling from the download script.

capture the depsolve logs for each blueprint separately

/assign @pacevedom @copejon

@dhellmann
USHIFT-1436: capture the depsolve logs for each blueprint separately
9c7a48f 
Having these logs in separate files should make debugging simpler.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 13, 2023 •
edited by openshift-ci bot

@dhellmann: This pull request references USHIFT-1436 which is a valid jira issue.

In response to this:

Download the composer logs for all of the builds performed and stage them
with unique filenames so they can be collected by the CI system.

Remove the redundant log handling from the download script.

capture the depsolve logs for each blueprint separately

/assign @pacevedom @copejon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann dhellmann mentioned this pull request Jul 13, 2023
Merged
@openshift-ci openshift-ci bot requested review from jogeo and pliurh July 13, 2023 20:26
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@dhellmann dhellmann changed the title USHIFT-1436: capture composer logs when building images WIP: USHIFT-1436: capture composer logs when building images Jul 13, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 13, 2023
@dhellmann
Copy link
Contributor Author

See https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/41239/rehearse-41239-pull-ci-openshift-microshift-main-microshift-metal-tests/1679563194349129728#1:build-log.txt%3A4695 for an example of a failed image build.

@dhellmann dhellmann force-pushed the USHIFT-1436-capture-composer-logs branch from 3317a1a to 26fdd46 Compare July 13, 2023 21:07
@dhellmann
USHIFT-1436: capture composer logs when building images
50c1cf0 
Download the composer logs for all of the builds performed and stage
them with unique filenames so they can be collected by the CI system.

Remove the redundant log handling from the download script.
@dhellmann
USHIFT-1436: only download images if the compose completes successfully
9904155
@dhellmann dhellmann force-pushed the USHIFT-1436-capture-composer-logs branch from 26fdd46 to 9904155 Compare July 13, 2023 21:36
@dhellmann dhellmann changed the title WIP: USHIFT-1436: capture composer logs when building images USHIFT-1436: capture composer logs when building images Jul 14, 2023
@dhellmann
Copy link
Contributor Author

/test microshift-metal-tests

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2023
@ggiguash
Copy link
Contributor

/lgtm
/hold

Please, unhold at your convenience to merge

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhellmann
Copy link
Contributor Author

Only the flakey CSI snapshot test failed.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 189e097 and 2 for PR HEAD 9904155 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2023

@dhellmann: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm 9904155 link false /test e2e-openshift-conformance-reduced-arm
ci/prow/microshift-metal-tests 9904155 link false /test microshift-metal-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e7833a5 into openshift:main Jul 14, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogeo jogeo Awaiting requested review from jogeo

@pliurh pliurh Awaiting requested review from pliurh

Assignees

@copejon copejon

@pacevedom pacevedom

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dhellmann @openshift-ci-robot @ggiguash @copejon @openshift-merge-robot @pacevedom