Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-1513: update rebase to work with kube-storage-version-migrator #2133

Conversation

dhellmann
Copy link
Contributor

The rebase script had assumed that all image and git repo names would
match, but they do not when we bring something from upstream into a fork.
Add support for a "via" argument to the "release" instruction in go.mod to
specify the git repository name. Then add the kube-storage-version-migrator
to the components included when we rebase.

/assign @pmtk @eggfoobar

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 27, 2023

@dhellmann: This pull request references USHIFT-1513 which is a valid jira issue.

In response to this:

The rebase script had assumed that all image and git repo names would
match, but they do not when we bring something from upstream into a fork.
Add support for a "via" argument to the "release" instruction in go.mod to
specify the git repository name. Then add the kube-storage-version-migrator
to the components included when we rebase.

/assign @pmtk @eggfoobar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from copejon and jerpeter1 July 27, 2023 21:59
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2023
@eggfoobar
Copy link
Contributor

LGTM

I'll leave it to @pmtk to add the label.

Thanks for doing this @dhellmann !

@pmtk
Copy link
Member

pmtk commented Jul 28, 2023

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2023
The rebase script had assumed that all image and git repo names would
match, but they do not when we bring something from upstream into a
fork. Add support for a "via" argument to the "release" instruction in
go.mod to specify the git repository name.
@dhellmann dhellmann force-pushed the USHIFT-1513-rebase-storage-migration-controller-with-rebase branch from 99e4fc1 to 2a29e92 Compare July 28, 2023 14:09
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2023
@pmtk
Copy link
Member

pmtk commented Jul 28, 2023

/lgtm
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmtk
Copy link
Member

pmtk commented Jul 28, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023
@openshift-merge-robot openshift-merge-robot merged commit d4f4fe8 into openshift:main Jul 28, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants