-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-1513: update rebase to work with kube-storage-version-migrator #2133
USHIFT-1513: update rebase to work with kube-storage-version-migrator #2133
Conversation
@dhellmann: This pull request references USHIFT-1513 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM I'll leave it to @pmtk to add the label. Thanks for doing this @dhellmann ! |
/retest |
The rebase script had assumed that all image and git repo names would match, but they do not when we bring something from upstream into a fork. Add support for a "via" argument to the "release" instruction in go.mod to specify the git repository name.
99e4fc1
to
2a29e92
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
The rebase script had assumed that all image and git repo names would
match, but they do not when we bring something from upstream into a fork.
Add support for a "via" argument to the "release" instruction in go.mod to
specify the git repository name. Then add the kube-storage-version-migrator
to the components included when we rebase.
/assign @pmtk @eggfoobar