Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-1518: deal with potential race condition in storage migration test #2141

Conversation

dhellmann
Copy link
Contributor

There may be a delay between pushing the CRD to the API server and having
it available for use to create a CR. Retry creating the CR a few times.

The restart keyword retries, so we do not need to retry when using it.
There may be a delay between pushing the CRD to the API server and
having it available for use to create a CR. Retry creating the CR a
few times.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 29, 2023

@dhellmann: This pull request references USHIFT-1518 which is a valid jira issue.

In response to this:

There may be a delay between pushing the CRD to the API server and having
it available for use to create a CR. Retry creating the CR a few times.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jerpeter1 and pliurh July 29, 2023 13:25
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2023
@dhellmann
Copy link
Contributor Author

/assign @eggfoobar

@eggfoobar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, eggfoobar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dhellmann,eggfoobar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3b05d27 and 2 for PR HEAD e17f10d in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2023

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit bd1bdc7 into openshift:main Jul 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants