OCPBUGS-19422: add test to look for errors in logs #2370
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci-robot
added
the
jira/invalid-bug
|
@dhellmann: This pull request references Jira Issue OCPBUGS-19422, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@dhellmann: This pull request references Jira Issue OCPBUGS-19422, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
dhellmann
force-pushed
the
OCPBUGS-19422-test-logs-for-permission-errors
branch
from
02ba54f
to
258ae52
Compare
test/suites/standard/log-scan.robot
Outdated
| Should Not Find Forbidden | ||
| [Documentation] Logs should not say "forbidden" | ||
| Pattern Should Not Appear In Log Output ${CURSOR} forbidden | ||
|
|
||
| Should Not Find Cannot Patch Resource | ||
| [Documentation] Logs should not say "cannot patch resource" | ||
| Pattern Should Not Appear In Log Output ${CURSOR} cannot patch resource | ||
|
|
||
| Should Find Etcd Is Ready | ||
| [Documentation] Logs should say "etcd is ready" | ||
| Pattern Should Appear In Log Output ${CURSOR} etcd is ready | ||
|
|
||
| Should Find MicroShift Is Ready | ||
| [Documentation] Logs should say "microshift is ready" | ||
| Pattern Should Appear In Log Output ${CURSOR} microshift is ready |
There was a problem hiding this comment.
Do we want to run these at the end of the other suites? Asking because I think it would be interesting as some sort of pre-suite-teardown instead of standalone tests. You would catch a wider variety of logs, as right now the test suite execution order is randomized.
There was a problem hiding this comment.
Today I'm mostly interested in looking for errors just from starting the service itself, not things triggered by the tests. I expect any test that might trigger an error to do its own check (the keywords here are all reusable for that).
There was a problem hiding this comment.
What about executing this one right after https://github.com/openshift/microshift/blob/main/test/bin/scenario.sh#L454-L461 ? That way you always ensure you are catching both the first start and the whole test. A test doing restarts might escape these checks because of randomization.
There was a problem hiding this comment.
I'm trying to avoid the global invariant pattern. This suite checks that we don't generate a few specific errors unrelated to any tests. After we merge it, we will have the keywords in place to allow each test suite to check conditions relevant to it, so that if we start seeing failures we know why we're checking those messages.
dhellmann
force-pushed
the
OCPBUGS-19422-test-logs-for-permission-errors
branch
from
258ae52
to
3e776c0
Compare
This commit adds a new test to check for some common permission-related errors that should never appear in the MicroShift logs.
dhellmann
force-pushed
the
OCPBUGS-19422-test-logs-for-permission-errors
branch
from
3e776c0
to
9176a2a
Compare
|
/test microshift-metal-tests |
|
/lgtm |
|
@dhellmann: This pull request references Jira Issue OCPBUGS-19422, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dhellmann: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@dhellmann: Jira Issue OCPBUGS-19422: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-19422 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit adds a new test to check for some common
permission-related errors that should never appear in the MicroShift
logs.
/assign @copejon @ggiguash @pmtk @pacevedom