OCPBUGS-22322: Don't create backups for current boot #2554
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci-robot
added
jira/valid-reference
|
@pmtk: This pull request references Jira Issue OCPBUGS-22322, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
/cherrypick release-4.14 |
|
@pmtk: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
pmtk
force-pushed
the
ocpbugs-22322-premature-backups
branch
from
ae53c24
to
8e6a30d
Compare
pmtk
force-pushed
the
ocpbugs-22322-premature-backups
branch
from
8e6a30d
to
88ac961
Compare
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
| @@ -86,6 +86,20 @@ func (dm *dataManagement) backup() error { | |||
| } | |||
| klog.InfoS("Contents of version file", "contents", versionFile) | |||
|
|
|||
| currentBootID, err := getCurrentBootID() | |||
There was a problem hiding this comment.
If we're no longer doing a backup on every startup, do we still need the boot ID in the backup name, or could we just use the ostree commit ID?
Other than that question, this looks good.
There was a problem hiding this comment.
I guess we could get rid of it. Backup's boot ID should be in version file, so it's not like we'd lose any info.
We'd have to change backing up: create new, delete old -> create tmp, rename into place.
Though I don't think we necessarily need to, there's no penalty for having this, right?
There was a problem hiding this comment.
If it complicates the backup procedure, I would not touch it.
|
/retest microshift-metal-tests-arm |
|
@pmtk: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test microshift-metal-tests-arm |
|
/retest |
|
@pmtk: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-4.14 |
|
@pmtk: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pmtk: Jira Issue OCPBUGS-22322: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-22322 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pmtk: new pull request created: #2591 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adds a check that prevents backup creation for current boot. Existence of such backup would prevent a proper backup (i.e. created on boot, with data compatible with previous boot) from being created (because microshift does not update backups - only creates new ones while deleting previous).