Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-23156: Rebase lvms registry.access.redhat.com lvms4 lvms operator bundle v4.14.1-4 #2598

Conversation

jakobmoellerdev
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev commented Nov 10, 2023

Which issue(s) this PR addresses:
Rebases on top of lvms 4.14.1 which contains the latest CSI sidecars for OCP 4.14

EDIT: Moved to OCPBUGS for smooth backport

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 10, 2023

@jakobmoellerdev: This pull request references USHIFT-1782 which is a valid jira issue.

In response to this:

Which issue(s) this PR addresses:
Rebases on top of lvms 4.14.1 which contains the latest CSI sidecars for OCP 4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev
Copy link
Contributor Author

/cherrypick release-4.14

@openshift-cherrypick-robot

@jakobmoellerdev: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev jakobmoellerdev changed the title USHIFT-1782: Rebase lvms registry.access.redhat.com lvms4 lvms operator bundle v4.14.1-4 OCPBUGS-23156: Rebase lvms registry.access.redhat.com lvms4 lvms operator bundle v4.14.1-4 Nov 10, 2023
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 10, 2023
@openshift-ci-robot
Copy link

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-23156, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Which issue(s) this PR addresses:
Rebases on top of lvms 4.14.1 which contains the latest CSI sidecars for OCP 4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 10, 2023
@openshift-ci-robot
Copy link

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-23156, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev
Copy link
Contributor Author

/cc @copejon

@openshift-ci openshift-ci bot requested a review from copejon November 10, 2023 13:56
@ggiguash
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023
@jakobmoellerdev jakobmoellerdev force-pushed the rebase-lvms-registry.access.redhat.com-lvms4-lvms-operator-bundle-v4.14.1-4 branch from 4b2af30 to e50d974 Compare November 17, 2023 09:32
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023
Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

@jakobmoellerdev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/microshift-metal-cache 4b2af30 link true /test microshift-metal-cache

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@copejon
Copy link
Contributor

copejon commented Nov 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2023
Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, ggiguash, jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ed001ce into openshift:main Nov 17, 2023
6 checks passed
@openshift-ci-robot
Copy link

@jakobmoellerdev: Jira Issue OCPBUGS-23156: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23156 has been moved to the MODIFIED state.

In response to this:

Which issue(s) this PR addresses:
Rebases on top of lvms 4.14.1 which contains the latest CSI sidecars for OCP 4.14

EDIT: Moved to OCPBUGS for smooth backport

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jakobmoellerdev: #2598 failed to apply on top of branch "release-4.14":

Applying: update last_lvms_rebase.sh
Using index info to reconstruct a base tree...
M	scripts/auto-rebase/last_lvms_rebase.sh
Falling back to patching base and 3-way merge...
Auto-merging scripts/auto-rebase/last_lvms_rebase.sh
CONFLICT (content): Merge conflict in scripts/auto-rebase/last_lvms_rebase.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 update last_lvms_rebase.sh
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev
Copy link
Contributor Author

/cherrypick release-4.14

@openshift-cherrypick-robot

@jakobmoellerdev: #2598 failed to apply on top of branch "release-4.14":

Applying: update last_lvms_rebase.sh
Using index info to reconstruct a base tree...
M	scripts/auto-rebase/last_lvms_rebase.sh
Falling back to patching base and 3-way merge...
Auto-merging scripts/auto-rebase/last_lvms_rebase.sh
CONFLICT (content): Merge conflict in scripts/auto-rebase/last_lvms_rebase.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 update last_lvms_rebase.sh
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants