Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-22338: Add base etcd version output to microshift-etcd #2633

Merged
merged 3 commits into from
Nov 25, 2023
Merged

OCPBUGS-22338: Add base etcd version output to microshift-etcd #2633

merged 3 commits into from
Nov 25, 2023

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Nov 21, 2023 •
edited

The output was modeled after microshift version command with its Base... notion.

$ ./microshift version
MicroShift Version: 4.15.0-0.nightly-2023-11-20-004519-20231121080816-4c70581df-dirty
Base OCP Version: 4.15.0-0.nightly-2023-11-20-004519

$ ./microshift-etcd version
MicroShift-etcd Version: 4.15.0-0.nightly-2023-11-20-004519-20231121080816-4c70581df-dirty
Base etcd Version: 3.5.10

The full output now presents etcdVersion new field

$ ./microshift-etcd version -o json
{
  "major": "4",
  "minor": "15",
  "gitVersion": "4.15.0-0.nightly-2023-11-20-004519-20231121080816-4c70581df-dirty",
  "gitCommit": "4c70581df",
  "gitTreeState": "dirty",
  "buildDate": "2023-11-21T11:54:57Z",
  "goVersion": "go1.20.10",
  "compiler": "gc",
  "platform": "linux/amd64",
  "patch": "0",
  "etcdVersion": "3.5.10"
}

The version information is also printed in the microshift-etcd logs

I1121 14:41:27.455098  174144 run.go:111] "Version" microshift-etcd="4.15.0-0.nightly-2023-11-20-004519-20231121115627-79ea2b86d-dirty" etcd-base="3.5.10"

/cc @sjug
/cc @pmtk

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 21, 2023
@openshift-ci-robot
Copy link

@ggiguash: This pull request references Jira Issue OCPBUGS-22338, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The output was modeled after microshift version command with its Base... notion.

$ ./microshift version
MicroShift Version: 4.15.0-0.nightly-2023-11-20-004519-20231121080816-4c70581df-dirty
Base OCP Version: 4.15.0-0.nightly-2023-11-20-004519

$ ./microshift-etcd version
MicroShift-etcd Version: 4.15.0-0.nightly-2023-11-20-004519-20231121080816-4c70581df-dirty
Base etcd Version: 3.5.10

The full output now presents etcdVersion new field

$ ./microshift-etcd version -o json
{
 "major": "4",
 "minor": "15",
 "gitVersion": "4.15.0-0.nightly-2023-11-20-004519-20231121080816-4c70581df-dirty",
 "gitCommit": "4c70581df",
 "gitTreeState": "dirty",
 "buildDate": "2023-11-21T11:54:57Z",
 "goVersion": "go1.20.10",
 "compiler": "gc",
 "platform": "linux/amd64",
 "patch": "0",
 "etcdVersion": "3.5.10"
}

/cc @sjug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from sjug November 21, 2023 12:01
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@openshift-ci-robot
Copy link

@ggiguash: This pull request references Jira Issue OCPBUGS-22338, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

The output was modeled after microshift version command with its Base... notion.

$ ./microshift version
MicroShift Version: 4.15.0-0.nightly-2023-11-20-004519-20231121080816-4c70581df-dirty
Base OCP Version: 4.15.0-0.nightly-2023-11-20-004519

$ ./microshift-etcd version
MicroShift-etcd Version: 4.15.0-0.nightly-2023-11-20-004519-20231121080816-4c70581df-dirty
Base etcd Version: 3.5.10

The full output now presents etcdVersion new field

$ ./microshift-etcd version -o json
{
 "major": "4",
 "minor": "15",
 "gitVersion": "4.15.0-0.nightly-2023-11-20-004519-20231121080816-4c70581df-dirty",
 "gitCommit": "4c70581df",
 "gitTreeState": "dirty",
 "buildDate": "2023-11-21T11:54:57Z",
 "goVersion": "go1.20.10",
 "compiler": "gc",
 "platform": "linux/amd64",
 "patch": "0",
 "etcdVersion": "3.5.10"
}

/cc @sjug
/cc @pmtk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor Author

/assign @pmtk

@pmtk
Copy link
Member

pmtk commented Nov 21, 2023

Looks nice. I have suggestion to also print these versions on startup, similar to what we have here: https://github.com/openshift/microshift/blob/main/pkg/cmd/run.go#L63-L64

@ggiguash
Copy link
Contributor Author

Looks nice. I have suggestion to also print these versions on startup, similar to what we have here: https://github.com/openshift/microshift/blob/main/pkg/cmd/run.go#L63-L64

@pmtk , I uploaded another commit and updated the PR description with a sample output.
Is this what you had in mind?

@pmtk
Copy link
Member

pmtk commented Nov 22, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 67b25fd and 2 for PR HEAD 8933097 in total

@sjug
Copy link
Contributor

sjug commented Nov 22, 2023

/lgtm

Tested and working as expected.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
@pmtk
Copy link
Member

pmtk commented Nov 23, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk, sjug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f3b2d07 and 2 for PR HEAD 981b2d3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 73c4a45 and 1 for PR HEAD 981b2d3 in total

@ggiguash
Copy link
Contributor Author

/test metal-periodic-test

@ggiguash
Copy link
Contributor Author

/test microshift-metal-cache

@ggiguash
Copy link
Contributor Author

/test metal-periodic-test

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 12374b9 and 0 for PR HEAD 981b2d3 in total

@openshift-ci-robot
Copy link

/hold

Revision 981b2d3 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2023
@ggiguash
Copy link
Contributor Author

The test failure has nothing to do with the etcd changes. It's a "known" problem in the Networking suite
/override microshift-metal-cache

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 25, 2023

@ggiguash: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • microshift-metal-cache

Only the following failed contexts/checkruns were expected:

  • ci/prow/images
  • ci/prow/metal-periodic-test
  • ci/prow/microshift-metal-cache
  • ci/prow/microshift-metal-tests
  • ci/prow/ocp-conformance-rhel-eus
  • ci/prow/test-unit
  • ci/prow/verify
  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-microshift-metal-cache
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-ocp-conformance-rhel-eus
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

The test failure has nothing to do with the etcd changes. It's a "known" problem in the Networking suite
/override microshift-metal-cache

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2023
@ggiguash
Copy link
Contributor Author

The test failure has nothing to do with the etcd changes. It's a "known" problem in the Networking suite
/override metal-periodic-test

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 25, 2023

@ggiguash: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • metal-periodic-test

Only the following failed contexts/checkruns were expected:

  • ci/prow/images
  • ci/prow/metal-periodic-test
  • ci/prow/microshift-metal-cache
  • ci/prow/microshift-metal-tests
  • ci/prow/ocp-conformance-rhel-eus
  • ci/prow/test-unit
  • ci/prow/verify
  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-microshift-metal-cache
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-ocp-conformance-rhel-eus
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

The test failure has nothing to do with the etcd changes. It's a "known" problem in the Networking suite
/override metal-periodic-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor Author

/override pull-ci-openshift-microshift-main-metal-periodic-test

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 25, 2023

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/metal-periodic-test

In response to this:

/override pull-ci-openshift-microshift-main-metal-periodic-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor Author

/override pull-ci-openshift-microshift-main-microshift-metal-cache

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 25, 2023

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/microshift-metal-cache

In response to this:

/override pull-ci-openshift-microshift-main-microshift-metal-cache

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6aa002f and 2 for PR HEAD 981b2d3 in total

@ggiguash
Copy link
Contributor Author

/test ocp-conformance-rhel-eus

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 25, 2023

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7738252 into openshift:main Nov 25, 2023
8 checks passed
@openshift-ci-robot
Copy link

@ggiguash: Jira Issue OCPBUGS-22338: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22338 has been moved to the MODIFIED state.

In response to this:

The output was modeled after microshift version command with its Base... notion.

$ ./microshift version
MicroShift Version: 4.15.0-0.nightly-2023-11-20-004519-20231121080816-4c70581df-dirty
Base OCP Version: 4.15.0-0.nightly-2023-11-20-004519

$ ./microshift-etcd version
MicroShift-etcd Version: 4.15.0-0.nightly-2023-11-20-004519-20231121080816-4c70581df-dirty
Base etcd Version: 3.5.10

The full output now presents etcdVersion new field

$ ./microshift-etcd version -o json
{
 "major": "4",
 "minor": "15",
 "gitVersion": "4.15.0-0.nightly-2023-11-20-004519-20231121080816-4c70581df-dirty",
 "gitCommit": "4c70581df",
 "gitTreeState": "dirty",
 "buildDate": "2023-11-21T11:54:57Z",
 "goVersion": "go1.20.10",
 "compiler": "gc",
 "platform": "linux/amd64",
 "patch": "0",
 "etcdVersion": "3.5.10"
}

The version information is also printed in the microshift-etcd logs

I1121 14:41:27.455098  174144 run.go:111] "Version" microshift-etcd="4.15.0-0.nightly-2023-11-20-004519-20231121115627-79ea2b86d-dirty" etcd-base="3.5.10"

/cc @sjug
/cc @pmtk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash ggiguash deleted the etcd_version branch November 28, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjug sjug Awaiting requested review from sjug

Assignees

@pmtk pmtk

@sjug sjug

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ggiguash @openshift-ci-robot @pmtk @sjug