Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-1883: Update OLM images at the right time #2650

Merged
merged 1 commit into from
Nov 28, 2023
Merged

USHIFT-1883: Update OLM images at the right time #2650

merged 1 commit into from
Nov 28, 2023

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Nov 24, 2023 •
edited

update_olm_images needs to be a part of update_openshift_manifests because that's when assets/ are commited. Otherwise some files will be lost after handle_assets.py deletes them, but they're not recreated at the right time.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2023 •
edited by openshift-ci bot

@pmtk: This pull request references USHIFT-1883 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pmtk pmtk force-pushed the 1883-fix-olm-image-update-place branch from c9e38ea to dcf7e89 Compare November 24, 2023 13:24
@pmtk pmtk changed the title USHIFT-1883: Update OLM images in right time USHIFT-1883: Update OLM images at the right time Nov 24, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@pmtk
Copy link
Member Author

pmtk commented Nov 24, 2023

/test test-rebsae

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

@pmtk: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test metal-periodic-test
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test ocp-conformance-rhel-eus
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-ocp-conformance-rhel-eus
  • pull-ci-openshift-microshift-main-test-rebase
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test test-rebsae

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk
Copy link
Member Author

pmtk commented Nov 24, 2023

/test test-rebase

@pmtk
Copy link
Member Author

pmtk commented Nov 24, 2023

/test verify

@pmtk pmtk mentioned this pull request Nov 24, 2023
Closed
@pmtk pmtk marked this pull request as ready for review November 24, 2023 14:10
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2023 •
edited by openshift-ci bot

@pmtk: This pull request references USHIFT-1883 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

update_olm_images needs to be a part of update_openshift_manifests because that's when assets/ are commited. Otherwise some files will be lost after handle_assets.py deletes them, but they're not recreated at the right time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmprusi
Copy link
Contributor

jmprusi commented Nov 24, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmprusi, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 73c4a45 and 2 for PR HEAD dcf7e89 in total

@jmprusi
Copy link
Contributor

jmprusi commented Nov 24, 2023

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 12374b9 and 1 for PR HEAD dcf7e89 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6aa002f and 0 for PR HEAD dcf7e89 in total

@openshift-ci-robot
Copy link

/hold

Revision dcf7e89 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2023
@ggiguash
Copy link
Contributor

/test microshift-metal-tests

@pmtk
Copy link
Member Author

pmtk commented Nov 27, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2023
@pmtk pmtk mentioned this pull request Nov 27, 2023
Closed
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7738252 and 2 for PR HEAD dcf7e89 in total

@pmtk
Copy link
Member Author

pmtk commented Nov 27, 2023

/retest

@pmtk pmtk mentioned this pull request Nov 27, 2023
Merged
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 15e3e7b and 1 for PR HEAD dcf7e89 in total

@jmprusi
Copy link
Contributor

jmprusi commented Nov 27, 2023

/retest-required

3 similar comments
@jmprusi
Copy link
Contributor

jmprusi commented Nov 27, 2023

/retest-required

@jmprusi
Copy link
Contributor

jmprusi commented Nov 27, 2023

/retest-required

@jmprusi
Copy link
Contributor

jmprusi commented Nov 27, 2023

/retest-required

@pmtk
Copy link
Member Author

pmtk commented Nov 27, 2023 

ERROR: ContainerResolveError: failed to resolve container: '': error getting manifest: reading manifest sha256:c9107c8ffaa6e01fdcb2f61c1e8d71e5b61c09cb6851bb1a1eb951570eccfc5b in registry.access.redhat.com/ubi8/openssl: received unexpected HTTP status: 502 Bad Gateway; '': error getting manifest: can't talk to a V1 container registry; '': error getting manifest: reading manifest sha256:ad28f7fe718f32127fff0b56949714c396306ebcbffd4192d911fd9a10aaabf8 in quay.io/openshift-release-dev/ocp-v4.0-art-dev: received unexpected HTTP status: 502 Bad Gateway; '': error getting manifest: can't talk to a V1 container registry; '': error getting manifest: Requesting bearer token: invalid status code from registry 500 (Internal Server Error)

@jmprusi
Copy link
Contributor

jmprusi commented Nov 27, 2023

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4c154e4 and 0 for PR HEAD dcf7e89 in total

@openshift-ci-robot
Copy link

/hold

Revision dcf7e89 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2023
@pmtk
Copy link
Member Author

pmtk commented Nov 28, 2023

/retest-required
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2023
@pmtk pmtk mentioned this pull request Nov 28, 2023
Closed
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7b3e7eb and 2 for PR HEAD dcf7e89 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a22f737 and 1 for PR HEAD dcf7e89 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ccb6bd0 into openshift:main Nov 28, 2023
9 checks passed
@pmtk pmtk deleted the 1883-fix-olm-image-update-place branch December 15, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copejon copejon Awaiting requested review from copejon

@pliurh pliurh Awaiting requested review from pliurh

Assignees

@jmprusi jmprusi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pmtk @openshift-ci-robot @jmprusi @ggiguash