Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-1948: Fail fast for the greenboot checks in scenario.sh #2660

Merged
merged 2 commits into from
Nov 30, 2023
Merged

USHIFT-1948: Fail fast for the greenboot checks in scenario.sh #2660

merged 2 commits into from
Nov 30, 2023

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Nov 28, 2023 •
edited

  • When greenboot reports "failed" status, stop the wait loop
  • Add functionality to reopen junit files
  • Implement a w/a for USHIFT-1952 by deleting TopoLVM pods and retrying greenboot checks

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ggiguash
Copy link
Contributor Author

/test microshift-metal-test

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

@ggiguash: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test metal-periodic-test
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test ocp-conformance-rhel-eus
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test microshift-metal-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests

@ggiguash ggiguash force-pushed the fail_fast_greenboot branch 2 times, most recently from dbaa37a to 3bc072a Compare November 28, 2023 09:20
@ggiguash ggiguash changed the title WIP: Fail fast for the greenboot checks in schenario.sh USHIFT-1948: Fail fast for the greenboot checks in schenario.sh Nov 28, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2023 •
edited by openshift-ci bot

@ggiguash: This pull request references USHIFT-1948 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash ggiguash changed the title USHIFT-1948: Fail fast for the greenboot checks in schenario.sh USHIFT-1948: Fail fast for the greenboot checks in scenario.sh Nov 28, 2023
@ggiguash ggiguash marked this pull request as ready for review November 28, 2023 09:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2023
@ggiguash ggiguash force-pushed the fail_fast_greenboot branch 3 times, most recently from 6a87c09 to e1cbc2e Compare November 28, 2023 17:28
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2023 •
edited by openshift-ci bot

@ggiguash: This pull request references USHIFT-1948 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

  • When greenboot for "failed" status and stop the wait loop
  • Add functionality to reopen junit files
  • Implement a w/a for USHIFT-1952 by deleting TopoLVM pods and retrying greenboot checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2023 •
edited by openshift-ci bot

@ggiguash: This pull request references USHIFT-1948 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

  • When greenboot for "failed" status and stop the wait loop
  • Add functionality to reopen junit files
  • Implement a w/a for USHIFT-1952 by deleting TopoLVM pods and retrying greenboot checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2023 •
edited by openshift-ci bot

@ggiguash: This pull request references USHIFT-1948 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

  • When greenboot reports "failed" status, stop the wait loop
  • Add functionality to reopen junit files
  • Implement a w/a for USHIFT-1952 by deleting TopoLVM pods and retrying greenboot checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash ggiguash force-pushed the fail_fast_greenboot branch 2 times, most recently from 92e6406 to 590f6ac Compare November 29, 2023 05:33
@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests metal-periodic-test

@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests metal-periodic-test

1 similar comment
@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests metal-periodic-test

@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests metal-periodic-test

@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests metal-periodic-test

dhellmann
dhellmann reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The retry logic looks good. I've done some different work that will conflict with the junit changes but solves the problem in a more robust way, so maybe we can agree on the order to merge.

test/bin/scenario.sh Outdated Show resolved Hide resolved
@ggiguash ggiguash mentioned this pull request Nov 30, 2023
Merged
@pmtk
Copy link
Member

pmtk commented Nov 30, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@ggiguash
Copy link
Contributor Author

/test metal-periodic-test microshift-metal-tests

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@pmtk
Copy link
Member

pmtk commented Nov 30, 2023

/lgtm
/hold

@ggiguash
Copy link
Contributor Author

/test metal-periodic-test microshift-metal-tests

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Nov 30, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor Author

/test metal-periodic-test

@ggiguash
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d7c5dd1 into openshift:main Nov 30, 2023
6 checks passed
@ggiguash ggiguash deleted the fail_fast_greenboot branch December 2, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann dhellmann left review comments

@pmtk pmtk pmtk left review comments

@jogeo jogeo Awaiting requested review from jogeo

@pacevedom pacevedom Awaiting requested review from pacevedom

Assignees

@pmtk pmtk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ggiguash @openshift-ci-robot @pmtk @dhellmann