Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-1977: add strictfipsruntime tag to microshift binary build #2699

Merged
merged 1 commit into from
Dec 8, 2023
Merged

USHIFT-1977: add strictfipsruntime tag to microshift binary build #2699

merged 1 commit into from
Dec 8, 2023

Conversation

eslutsky
Copy link
Contributor

@eslutsky eslutsky commented Dec 7, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 7, 2023 •
edited by openshift-ci bot

@eslutsky: This pull request references USHIFT-1977 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
dhellmann
dhellmann reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

One nit, but nothing worth holding up the PR. I'll leave a hold in place in case there are test issues. Feel free to remove it when you're ready to merge.

Makefile Show resolved Hide resolved
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
@eslutsky
Copy link
Contributor Author

eslutsky commented Dec 7, 2023

it appears that those build flags only works with podman build (doesnt work with upstream golang builds)

@eslutsky
USHIFT-1977: add strictfipsruntime tags for FIPS compliance
28ab303 
Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
dhellmann
dhellmann reviewed Dec 7, 2023
View reviewed changes
Makefile Show resolved Hide resolved
@eslutsky
Copy link
Contributor Author

eslutsky commented Dec 7, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2023
@eslutsky
Copy link
Contributor Author

eslutsky commented Dec 8, 2023

@dhellmann , can you re-approve please, the label was removed.

@dhellmann
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, eslutsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9c35c37 and 2 for PR HEAD 28ab303 in total

@dhellmann
Copy link
Contributor

/override ci/prow/microshift-metal-tests

The failing test (el92-src@storage.Reboot: Rebooting Healthy System Should Keep Functional PVC ) is not related to this change.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

@dhellmann: Overrode contexts on behalf of dhellmann: ci/prow/microshift-metal-tests

In response to this:

/override ci/prow/microshift-metal-tests

The failing test (el92-src@storage.Reboot: Rebooting Healthy System Should Keep Functional PVC ) is not related to this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

@eslutsky: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d1c345f into openshift:main Dec 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann dhellmann left review comments

@jogeo jogeo Awaiting requested review from jogeo

Assignees

@dhellmann dhellmann

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eslutsky @openshift-ci-robot @dhellmann