Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] USHIFT-2135: Fix unbuffer not to run elevated when executing virt-install command #2825

Merged
merged 1 commit into from
Jan 1, 2024
Merged

[release-4.14] USHIFT-2135: Fix unbuffer not to run elevated when executing virt-install command #2825

merged 1 commit into from
Jan 1, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2819

/assign ggiguash

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 1, 2024
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 1, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: [Jira Issue USHIFT-2132](https://issues.redhat.com//browse/USHIFT-2132) has been cloned as [Jira Issue USHIFT-2135](https://issues.redhat.com//browse/USHIFT-2135). Will retitle bug to link to clone.

WARNING: Failed to update the target version for the clone. Please update the target version manually. Full error below:

Full error message. customfield_12319940 - Version name '4.14.z' is not valid: request failed. Please analyze the request body for more details. Status code: 400:
/retitle [release-4.14] [USHIFT-2135](https://issues.redhat.com//browse/USHIFT-2135): Fix unbuffer not to run elevated when executing virt-install command

In response to this:

This is an automated cherry-pick of #2819

/assign ggiguash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] USHIFT-2132: Fix unbuffer not to run elevated when executing virt-install command [release-4.14] USHIFT-2135: Fix unbuffer not to run elevated when executing virt-install command Jan 1, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 1, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 1, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references USHIFT-2135 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.14." or "openshift-4.14.", but it targets "openshift-4.15" instead.

In response to this:

This is an automated cherry-pick of #2819

/assign ggiguash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dhellmann and pmtk January 1, 2024 10:38
@ggiguash
Copy link
Contributor

ggiguash commented Jan 1, 2024

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 1, 2024 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-2135 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 1, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ggiguash
Copy link
Contributor

ggiguash commented Jan 1, 2024

/lgtm
/label backport-risk-assessed
/label jira/valid-bug
/label cherrypick-approved

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 1, 2024

@ggiguash: The label(s) /label cherrypick-approved cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/invalid-bug, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/lgtm
/label backport-risk-assessed
/label jira/valid-bug
/label cherrypick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 1, 2024
@ggiguash
Copy link
Contributor

ggiguash commented Jan 1, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 1, 2024
@ggiguash
Copy link
Contributor

ggiguash commented Jan 1, 2024

/label backport-risk-assessed

@openshift-merge-bot openshift-merge-bot bot merged commit 444c306 into openshift:release-4.14 Jan 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann Awaiting requested review from dhellmann

@pmtk pmtk Awaiting requested review from pmtk

Assignees

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @ggiguash