Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-2183: Make sos report collection more robust in scenario.sh #2873

Merged
merged 1 commit into from
Jan 20, 2024
Merged

USHIFT-2183: Make sos report collection more robust in scenario.sh #2873

merged 1 commit into from
Jan 20, 2024

Conversation

ggiguash
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2024 •
edited by openshift-ci bot

@ggiguash: This pull request references USHIFT-2183 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2024
@ggiguash ggiguash changed the title USHIFT-2183: Allocate ssh pseudo-terminal only in interactive sessions USHIFT-2183: Make sos report collection more robust in scenario.sh Jan 14, 2024
@ggiguash ggiguash force-pushed the ssh_terminal branch 2 times, most recently from 3820a43 to 9a0bc88 Compare January 14, 2024 21:41
copejon
copejon reviewed Jan 15, 2024
View reviewed changes
test/bin/scenario.sh Outdated Show resolved Hide resolved
pmtk
pmtk reviewed Jan 16, 2024
View reviewed changes
test/bin/scenario.sh Outdated Show resolved Hide resolved
dhellmann
dhellmann reviewed Jan 16, 2024
View reviewed changes
test/bin/scenario.sh Outdated Show resolved Hide resolved
test/bin/scenario.sh Outdated Show resolved Hide resolved
@ggiguash
Copy link
Contributor Author

Cloud formation failure
/test microshift-metal-tests-arm

dhellmann
dhellmann reviewed Jan 17, 2024
View reviewed changes
test/bin/scenario.sh Outdated Show resolved Hide resolved
@pmtk
Copy link
Member

pmtk commented Jan 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a79401d and 2 for PR HEAD 0830c85 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6b75114 and 1 for PR HEAD 0830c85 in total

@ggiguash
Copy link
Contributor Author

/test test-unit verify

@pmtk
Copy link
Member

pmtk commented Jan 19, 2024

/test verify

1 similar comment
@ggiguash
Copy link
Contributor Author

/test verify

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 20, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 79b8337 into openshift:main Jan 20, 2024
8 checks passed
@ggiguash
Copy link
Contributor Author

/cherry-pick release-4.15

@ggiguash ggiguash deleted the ssh_terminal branch January 20, 2024 09:44
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 20, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ggiguash: new pull request created: #2906

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann dhellmann left review comments

@pmtk pmtk pmtk left review comments

@copejon copejon copejon left review comments

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@pliurh pliurh Awaiting requested review from pliurh

Assignees

@pmtk pmtk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ggiguash @openshift-ci-robot @pmtk @openshift-cherrypick-robot @dhellmann @copejon