Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] USHIFT-2192: force versions in rpm install test #2890

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[release-4.15] USHIFT-2192: force versions in rpm install test #2890

merged 1 commit into from
Jan 17, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2887

/assign dhellmann

@dhellmann
force versions in rpm install test
b9fe940 
Instead of relying on the host to only have repos configured for the
version we want, specify the version to use when installing the
RPM. This ensures that after a GA release the source package, with a
x.y.0 nightly version, can override the version from the standard
repos, with a newer version.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2024
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: USHIFT-2191

In response to this:

This is an automated cherry-pick of #2887

/assign dhellmann

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jogeo and pliurh January 17, 2024 12:28
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhellmann dhellmann changed the title [release-4.15] USHIFT-2191: force versions in rpm install test [release-4.15] USHIFT-2192: force versions in rpm install test Jan 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references USHIFT-2192 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "openshift-4.16" instead.

In response to this:

This is an automated cherry-pick of #2887

/assign dhellmann

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2024
@dhellmann
Copy link
Contributor

/approve
/lgtm
/label backport-risk-assessed
/label jira/valid-bug

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. labels Jan 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@pacevedom
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2bfa7ed into openshift:release-4.15 Jan 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogeo jogeo Awaiting requested review from jogeo

@pliurh pliurh Awaiting requested review from pliurh

Assignees

@dhellmann dhellmann

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @openshift-ci-robot @dhellmann @pacevedom