Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-2105: cert rotation test wait for greenboot #2891

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

pacevedom
Copy link
Contributor

This test changes the time immediately after starting. If the test is executed when the system is running greenboot (from a reboot, for example), the time warp makes it fail with fake timeouts, as time jumped to the future. Depending on the test execution order this might happen randomly.
Force waiting for greenboot before starting to avoid glitches.

Which issue(s) this PR addresses:

Closes #

This test changes the time immediately after starting. If the test
is executed when the system is running greenboot (from a reboot, for
example), the time warp makes it fail with fake timeouts, as time
jumped to the future. Depending on the test execution order this
might happen randomly.
Force waiting for greenboot before starting to avoid glitches.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2024

@pacevedom: This pull request references USHIFT-2105 which is a valid jira issue.

In response to this:

This test changes the time immediately after starting. If the test is executed when the system is running greenboot (from a reboot, for example), the time warp makes it fail with fake timeouts, as time jumped to the future. Depending on the test execution order this might happen randomly.
Force waiting for greenboot before starting to avoid glitches.

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jogeo and pliurh January 17, 2024 14:10
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a79401d into openshift:main Jan 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants